From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1F317DA64 for ; Fri, 16 Aug 2024 05:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723786116; cv=none; b=bYJNfYGEXLsDgVeLurRXYlVsZnM6+iQ5qrJ9aMxZcnYZs0YPyCrWyEpM+5ZPeFGi/zHxxPN4wv6dhKeURVM5adqsvNFRHVkUnT3tgRKilJgpznTmQHMShVxe099xsfpMc+lKcYQPJTslHvDEXXLq9AyO0MpYH5t3LNEYQH0+1v0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723786116; c=relaxed/simple; bh=qrNovx/o/2X2PhqWbW9MYPt5t5yS8k1HRNlOgGOixMw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RJdEXP93ItH6jvKa7IWekx/4vIU/7Wggy35bsBVDS2zmgod2HOUiUO3Jy4I0UGBQ4OyASVaN17c9ePXXJcUv2zliMT1/KQuZFrROjMt5xmCVjru7t73+THZe+gMcMWHvUjWzlrUg4zRmZ3W/oHhDEIIhfUkUAv95Jv5bGpFOMDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n6mG8/hQ; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n6mG8/hQ" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-367990aaef3so890606f8f.0 for ; Thu, 15 Aug 2024 22:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723786113; x=1724390913; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=GhHeGH6cQdxvT4dPdZNPTWXPSTNYzO+pPaEBDOXhyXk=; b=n6mG8/hQaxrBCThOMKdPLVmtEQHJDefUgY6gvAwDDhfPqumk56pzzcYPXyzDbMFu8L fxWT6wIseu1hlpV+oaV721IdPKF/SJvIXy4dYp31XE1bENya7Z1AR+JjrIlVdEyjumwZ 5WEdQLxUQJhZ94isRNa03ClWbGB8YdJKC91ycLenHw8fmLKdKPRHkieI4Aq5G9NUB8vg IWqpPPyJEuOvHg+vmvytsi16DEqCGRv8YechgXKFtlYvBThV+OXGpDm4rlyLd4yH2B3f bj0YNIBRtTTknGSYXGJPFmNzbXrywXGupYuHskavzLowKnn8J+mA8DEiHLTbEa6b2Vbn 7llg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723786113; x=1724390913; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GhHeGH6cQdxvT4dPdZNPTWXPSTNYzO+pPaEBDOXhyXk=; b=wOGpPQIaSnkzYh0KD9IvxEPzx1SqDMAMiCspJ8Lhlon+17zLUGU2NJ7jWB/63zkJkm 8jqX38UBYLKZqiIXck3U/+mmkRiQNR1jQeZsrVu70ZVA8wM4YqHFF1hcq8blJosSnQBY 4cCZzKn6Z5eICVoes/5QLnCRmqEJgma4sWEeE4mj4hp57IGZ/0JJSE0TfDWiofrCNExi KdAl5tEjiYUYm5Hl9h2YipI0tmBqL0Lyem8NOBjlSMiW3KD9BqYj9EdJ8xgI4NZiFDG0 6j0xr0gGH6aaj1P0abuYImcr+N7RLic5h2xCEn/scm+vrjIC3EP7U71jQWhs9iGncsC6 JLBA== X-Forwarded-Encrypted: i=1; AJvYcCVkJU8iuyE35UAaSZDx+Ku36rS/G0+SL0I3zpmHkb08B4gW/QdjO4siPuSFcSvIQJE+huI0CNAysI+9+oRbV/KJIsL3K9xnJPOHvXg= X-Gm-Message-State: AOJu0YwSQFUdcVuo7mh2kaDB/HYnaHktsP2c1zPqzr9AMQZaCiasXrH4 Un3chfdgKhhii5IXFp9vXInjzWVi0r2kNUWoIlsI7wwUM3T830v1PlONTzE2aGI= X-Google-Smtp-Source: AGHT+IFvJjELXTxMyF/q4ovz2yV4ms39xOEJ4XibnCeJh+vYYng+q6EhD792uwgat2JaJUadZkVVAw== X-Received: by 2002:adf:ef4b:0:b0:368:6d75:1bde with SMTP id ffacd0b85a97d-37194328c78mr1071469f8f.15.1723786113057; Thu, 15 Aug 2024 22:28:33 -0700 (PDT) Received: from [192.168.1.20] ([178.197.215.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37189897029sm2821854f8f.74.2024.08.15.22.28.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Aug 2024 22:28:32 -0700 (PDT) Message-ID: Date: Fri, 16 Aug 2024 07:28:30 +0200 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] thermal: of: Use scoped device node handling to simplify thermal_of_trips_init() To: Chen-Yu Tsai Cc: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Amit Kucheria , Thara Gopinath , Thierry Reding , Jonathan Hunter , Vasily Khoruzhick , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20240814-b4-cleanup-h-of-node-put-thermal-v1-0-7a1381e1627e@linaro.org> <20240814-b4-cleanup-h-of-node-put-thermal-v1-2-7a1381e1627e@linaro.org> <20240815071538.GB350960@google.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240815071538.GB350960@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/08/2024 09:15, Chen-Yu Tsai wrote: >> >> tt = kzalloc(sizeof(*tt) * count, GFP_KERNEL); >> - if (!tt) { >> - ret = -ENOMEM; >> - goto out_of_node_put; >> - } >> + if (!tt) >> + return ERR_PTR(-ENOMEM); >> >> *ntrips = count; > > Also drop the "of_node_put(trips);" in the successful path? > Right. Best regards, Krzysztof