From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E1571384AC for ; Tue, 23 Apr 2024 12:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713876236; cv=none; b=mlIC/bEbuTFpr3JKOVekwcINp4yDFojHIOBGQm/ya59LER0YvhBUAcVhzXHWofGF2POEkuoJvEITfclhwlZ8sAuNCbl+NT3SmoEF1ckg8HehRRp4GOvli5ujcxqPNzfutE4QKze0KQlGrscJ0JYw5uNcCPbGAZjdcK2kNH3zXaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713876236; c=relaxed/simple; bh=r0UmnNWiljWy3w/DWQQ7Ic6mYcT+iVhIRMPUeFTh3tM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bcvSD8eUAXgZScskmb1XsPx/NxaDynXVOXF9Cl5i6Pgzel3hFhmHC3isx+joTrUq241haNzBqP9Ih876JZswzI8355QCKdq+6pHh6wclE18kVXsyE2xJTTHc1I+NBGaR/nMEDiVm1zM2GMUZaA+sr9+czAS0ewaOc1OXAQW0XHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VE3pQ/8K; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VE3pQ/8K" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-349c4505058so4379111f8f.3 for ; Tue, 23 Apr 2024 05:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713876232; x=1714481032; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+qnKAwgvBHM35XCDpuBit4GUKItb+LTK0jOfybUvb7k=; b=VE3pQ/8KsNBMJMos9vf9NNNHeUqGpQYYjL5pbhHv+K8pTpPgW2J6atK0TZVnIEvkQX kYmmtvoVz6kHejaOWs2PJF5UsQqpXZjRQLhZe3uw9ZbgbzWaqfEdT7+W9aJ3sOPwXHeT iPiG5oha9sjqjByJUBtOmIAxCB54M7fZg6xWYhWAZJtZsOdqNL3W+GdnaNdVTun3KNNf wyoWbQug7Zn+Yojn2cwxSGk6lGTPksaQGt9yDBK8zuRoHHstn9Bc1+AgbHpPYleAU7WT R2OATXbkNg39IJdgRUQPmb7OzJDybwTPgQ1Nk7tIfbIrQACPUBl06PBzapBANSoufjdP ezSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713876232; x=1714481032; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+qnKAwgvBHM35XCDpuBit4GUKItb+LTK0jOfybUvb7k=; b=Az+urY7zVyf8BkIbkK5pAgF5SyghpFmEjT/YCRFzj6AJYEDWdzlNqgl3F0+njYN06h ZycJcNT8hAQt9TvCgLJukygIWzPaZgPWvN+5QBogOCtNyHupPk6zQrj2VtP5zwZCN4st BuBNNlPgD4sLf2oSDUdhUBykopKV/g3xGAyfic2/O+hzXZJMoxvBWd0RoXhiJ3nAtTLK o3EkRmv3uzY1B2Pevh4sRkjhxxPrjhLV5KJIFFM3R3X88Tkp1t7uoZ4/2KHEQmT05G5S qVu8UMctRk+18O0KOsBv8Y1M/d+EMB5weOp05PRiozL/61nwoJGY+7GO6tZJcKTx2VDG 2HoA== X-Forwarded-Encrypted: i=1; AJvYcCW9y5TQZqTbS04rupRckxT3sTiL3NzcIY1CtrrdxAychS4s+N2NvrZwo4keo1HkwKengenhY+L3rTvsFzTKEegT2f8aCBPedRN0uxY= X-Gm-Message-State: AOJu0YzVBtxLam6gXEBOtYTX2fVp5Nc55W2Lr/1G3fenNnw95o+fQlwX y2d8PqAPou5Q8QbsTE81biz8qaCxJalDcS5AsARdrvbd/hTmucux2Phx0Ovid98= X-Google-Smtp-Source: AGHT+IHx5NN+z23VludiFeHTrKmrJCe4gLG+r1lTx6C4j7QEMysWQLMdtEpvLnQqAlOL1NQMbBj3Zg== X-Received: by 2002:a5d:6a8d:0:b0:34b:5caf:6342 with SMTP id s13-20020a5d6a8d000000b0034b5caf6342mr2073298wru.67.1713876232556; Tue, 23 Apr 2024 05:43:52 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id r16-20020a5d6950000000b003477d26736dsm14506412wrw.94.2024.04.23.05.43.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 05:43:52 -0700 (PDT) Message-ID: Date: Tue, 23 Apr 2024 13:43:49 +0100 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/35] media: s2255: Use refcount_t instead of atomic_t for num_channels To: Ricardo Ribalda , Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Pavel Machek Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-11-477afb23728b@chromium.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240415-fix-cocci-v1-11-477afb23728b@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/04/2024 20:34, Ricardo Ribalda wrote: > Use an API that resembles more the actual use of num_channels. > > Found by cocci: > drivers/media/usb/s2255/s2255drv.c:2362:5-24: WARNING: atomic_dec_and_test variation before object free at line 2363. > drivers/media/usb/s2255/s2255drv.c:1557:5-24: WARNING: atomic_dec_and_test variation before object free at line 1558. Hmm, that commit log needs more detail. "Convert from atomic_t to refcount_t because refcount_t has memory ordering guarantees which atomic does not, hence the WARNING for the free after the atomic dec." Something like that. I'll leave it up to yourself to decide if this warrants a Fixes: I don't think so myself because the previous code doesn't seem to matter to the decrement and free. --- bod