From: Samuel Holland <samuel@sholland.org>
To: Andre Przywara <andre.przywara@arm.com>,
Jagan Teki <jagan@amarulasolutions.com>
Cc: u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>,
Icenowy Zheng <uwu@icenowy.me>,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
Jesse Taube <mr.bossman075@gmail.com>,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] sunxi: f1c100s: re-enable SYSRESET
Date: Sat, 14 Jan 2023 14:30:55 -0600 [thread overview]
Message-ID: <d7df09c2-408b-e14e-a5d8-072fd71b3ae9@sholland.org> (raw)
In-Reply-To: <20230105020451.19256-1-andre.przywara@arm.com>
On 1/4/23 20:04, Andre Przywara wrote:
> The SoC .dtsi originally submitted for the Allwinner F1C100s had the
> wrong compatible string for the watchdog, which broke U-Boot's reset
> functionality. To quickly fix this, we disable CONFIG_SYSRESET in
> cfcf1952c11e6ffcbbf88 ("sunxi: f1c100s: Drop SYSRESET to enable reset
> functionality"), so that U-Boot's hardcoded reset driver could take over.
>
> After this was properly fixed in the devicetree, we reverted that patch
> in 92373de041ea ("Revert "sunxi: f1c100s: Drop SYSRESET to enable reset
> functionality"), however this line sneaked back in with d0ee7f295d74
> ("Convert CONFIG_SYS_PBSIZE to Kconfig"), so during a Kconfig update.
>
> Remove this line (again), to use the proper reset driver.
>
> Fixes: d0ee7f295d74 ("Convert CONFIG_SYS_PBSIZE to Kconfig")
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> Hi,
>
> this is not critical (so nothing for 2023.01), reset works either way.
> But we should fix it anyway.
>
> Cheers,
> Andre
>
> configs/licheepi_nano_defconfig | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Samuel Holland <samuel@sholland.org>
prev parent reply other threads:[~2023-01-14 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 2:04 [PATCH] sunxi: f1c100s: re-enable SYSRESET Andre Przywara
2023-01-14 20:30 ` Samuel Holland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7df09c2-408b-e14e-a5d8-072fd71b3ae9@sholland.org \
--to=samuel@sholland.org \
--cc=andre.przywara@arm.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=jagan@amarulasolutions.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=mr.bossman075@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox