From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Samuel Holland <samuel@sholland.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: LABBE Corentin <clabbe.montjoie@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: net: sun7i-gmac: Fix snps,dwmac.yaml inheritance
Date: Sat, 26 Nov 2022 14:25:11 +0100 [thread overview]
Message-ID: <d84ff258-d3e1-45e0-4473-7cd0707ae17f@linaro.org> (raw)
In-Reply-To: <20221125202008.64595-2-samuel@sholland.org>
On 25/11/2022 21:20, Samuel Holland wrote:
> The sun7i-gmac binding extends snps,dwmac.yaml, and should accept all
> properties defined there, including "mdio", "resets", and "reset-names".
> However, validation currently fails for these properties because the
> local binding sets "unevaluatedProperties: false", and snps,dwmac.yaml
> is only included inside an allOf block. Fix this by referencing
> snps,dwmac.yaml at the top level.
>
I don't understand where is the problem and how does your patch solve
it. The old syntax is correct and your change does nothing, no fixing,
no impact. It actually looks like noop with big explanation :(
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-26 13:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 20:20 [PATCH 0/3] dt-bindings: net: sunxi: Fix binding validation issues Samuel Holland
2022-11-25 20:20 ` [PATCH 1/3] dt-bindings: net: sun7i-gmac: Fix snps,dwmac.yaml inheritance Samuel Holland
2022-11-26 13:25 ` Krzysztof Kozlowski [this message]
2022-11-25 20:20 ` [PATCH 2/3] dt-bindings: net: sun8i-emac: " Samuel Holland
2022-11-26 13:26 ` Krzysztof Kozlowski
2022-11-26 14:28 ` Andre Przywara
2022-11-26 14:48 ` Krzysztof Kozlowski
2022-12-01 3:45 ` Rob Herring
2022-12-01 18:10 ` Rob Herring
2022-11-26 14:15 ` Krzysztof Kozlowski
2022-11-25 20:20 ` [PATCH 3/3] dt-bindings: net: sun8i-emac: Add phy-supply property Samuel Holland
2022-11-26 0:32 ` Andre Przywara
2022-11-26 13:37 ` Krzysztof Kozlowski
2022-12-01 21:49 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d84ff258-d3e1-45e0-4473-7cd0707ae17f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox