From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FDE27C for ; Mon, 2 Jan 2023 09:02:19 +0000 (UTC) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 30290Zj6030661; Mon, 2 Jan 2023 03:00:35 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1672650035; bh=Sfa9o0kdL5YsnLLCEDwGHRyigUI/UlPkkJoDS6qgMKI=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=VIeoKP1qktpphB0/sTMLIYm+IKZVhDH3qZme5rr6HJBIks4bTkkltIfgfdiVdevS3 vTvKWi3jB8vYAh8vsumR/LDpOTPQy/bE/mGsPl8xjEaf7O2Xs4h+gcZK7ra169cVkX vIZuHvqBhliSdZn/ELshNkXQZr+6U6iq5b+Z6/FY= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 30290ZkC011689 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 2 Jan 2023 03:00:35 -0600 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Mon, 2 Jan 2023 03:00:34 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Mon, 2 Jan 2023 03:00:34 -0600 Received: from [172.24.223.105] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 30290Tna071884; Mon, 2 Jan 2023 03:00:30 -0600 Message-ID: Date: Mon, 2 Jan 2023 14:30:29 +0530 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 5/7] mtd: rawnand: sunxi: Fix the size of the last OOB region To: Samuel Holland , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Chen-Yu Tsai , Jernej Skrabec CC: Boris Brezillon , Brian Norris , , , , References: <20221229181526.53766-1-samuel@sholland.org> <20221229181526.53766-6-samuel@sholland.org> Content-Language: en-US From: "Gole, Dhruva" Organization: Texas Instruments Incorporated In-Reply-To: <20221229181526.53766-6-samuel@sholland.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 On 12/29/2022 11:45 PM, Samuel Holland wrote: > The previous code assigned to the wrong structure member. Good catch! > > Fixes: c66811e6d350 ("mtd: nand: sunxi: switch to mtd_ooblayout_ops") > Signed-off-by: Samuel Holland > --- Acked-By: Dhruva Gole > > drivers/mtd/nand/raw/sunxi_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c > index 1ecf2cee343b..8e873f4fec9a 100644 > --- a/drivers/mtd/nand/raw/sunxi_nand.c > +++ b/drivers/mtd/nand/raw/sunxi_nand.c > @@ -1609,7 +1609,7 @@ static int sunxi_nand_ooblayout_free(struct mtd_info *mtd, int section, > if (section < ecc->steps) > oobregion->length = 4; > else > - oobregion->offset = mtd->oobsize - oobregion->offset; > + oobregion->length = mtd->oobsize - oobregion->offset; > > return 0; > } -- Regards, Dhruva Gole