From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 452F07A for ; Sun, 24 Apr 2022 02:27:46 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 53DD45C00E8; Sat, 23 Apr 2022 22:27:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 23 Apr 2022 22:27:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1650767265; x= 1650853665; bh=5aHnylZhBrIbPeHjOBkVxfTHbhAukjfHst0cFkOu57k=; b=u jE+1YolNokydrNd0C1U/GmGsRVaANV/H6vkM8dUz64h0BmoRdYlJ3M+UEt4ispal TpHYd4als3XGG0cGM8amlSTOzXm/kG6lxydg5a2sqSX6ClmEaBTq4UgzQHBJY0MS DrMSppSFDuZi+4QD8eZVzpPdFpGVAqEGcJbBGTQoVG0stqOY8gqnbAVrSZR3ukoo C5jecbWTjTXM4BKoV8JKIwLjx7zd0H0ba51qNdvs6Dv1hPsaE+M9dUnkdgKk/HFC FxOvi46mCpVolSITd/OUrKXDZEQCAr2LZ9lAQOIaZJ7t/f1x0z5ibq6bdcNzRXGc ehxgLDvgG659SeB/TLrQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1650767265; x=1650853665; bh=5aHnylZhBrIbP eHjOBkVxfTHbhAukjfHst0cFkOu57k=; b=ks72ZrlBVF7wPaLgoznPZzso4dUSy fjJwyimyA3yOGVQfz2oyRGmLJBLErO9X9mR2braEpx1gCBQmDpjRs1EK97QtDW+H BoQ/z17GMLLF+MmypF3LO7GyClV8BhnoXpaD87NUa8xzew35y1Hu/yXaQDK1oLJd zvYFFtTWdTp271uKPhkAZNG23gMvScmU4ahKbF//h98iTu+YEHFnESlsicgllzp6 DL3inBzcJ0OR2ofuU2iOYNxTVQVRx+KSevP/KogXqmV74alz1TD7RLn/MKF251h1 9BkOCbDoNCN7keuWUyqoqVQieORZyDl34OVZa4aMxDD96ZQzJ5McuAATA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrtdejgdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfevfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepffdtveekvdegkeeuueetgfetffeileevudekuefhheelvdfhiedt heduhfduhefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 23 Apr 2022 22:27:44 -0400 (EDT) Subject: Re: [PATCH 08/12] mmc: sunxi: add support for R329 MMC controllers To: Icenowy Zheng , Ulf Hansson , Linus Walleij Cc: Rob Herring , Chen-Yu Tsai , Jernej Skrabec , Andre Przywara , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Icenowy Zheng References: <20220422140902.1058101-1-icenowy@aosc.io> From: Samuel Holland Message-ID: Date: Sat, 23 Apr 2022 21:27:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/22/22 10:41 AM, icenowy@outlook.com wrote: > From: Icenowy Zheng > > The two MMC controllers in Allwinner R329 have a mixed feature set > comparing to the previous SoCs' ordinary MMC and eMMC controllers. > > Add support for them. > > Signed-off-by: Icenowy Zheng Acked-by: Samuel Holland > --- > drivers/mmc/host/sunxi-mmc.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c > index 0e8fbf4957d8..06934eef8be5 100644 > --- a/drivers/mmc/host/sunxi-mmc.c > +++ b/drivers/mmc/host/sunxi-mmc.c > @@ -1207,6 +1207,15 @@ static const struct sunxi_mmc_cfg sun50i_a100_emmc_cfg = { > .needs_new_timings = true, > }; > > +static const struct sunxi_mmc_cfg sun50i_r329_cfg = { > + .idma_des_size_bits = 13, > + .idma_des_shift = 2, > + .clk_delays = NULL, > + .can_calibrate = true, > + .mask_data0 = true, > + .needs_new_timings = true, > +}; > + This is the same as D1, so you could reuse or replace that configuration constant. Regards, Samuel > static const struct of_device_id sunxi_mmc_of_match[] = { > { .compatible = "allwinner,sun4i-a10-mmc", .data = &sun4i_a10_cfg }, > { .compatible = "allwinner,sun5i-a13-mmc", .data = &sun5i_a13_cfg }, > @@ -1218,6 +1227,7 @@ static const struct of_device_id sunxi_mmc_of_match[] = { > { .compatible = "allwinner,sun50i-a64-emmc", .data = &sun50i_a64_emmc_cfg }, > { .compatible = "allwinner,sun50i-a100-mmc", .data = &sun50i_a100_cfg }, > { .compatible = "allwinner,sun50i-a100-emmc", .data = &sun50i_a100_emmc_cfg }, > + { .compatible = "allwinner,sun50i-r329-mmc", .data = &sun50i_r329_cfg }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, sunxi_mmc_of_match); >