From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 968931FB6 for ; Sat, 4 Feb 2023 10:39:01 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A0B0F5C012C; Sat, 4 Feb 2023 05:39:00 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Sat, 04 Feb 2023 05:39:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1675507140; x=1675593540; bh=FcE/plgwiH cAVpfmlr0FqbcFN9q3FpSWErJCt2r3sUY=; b=mZybz0G+RrfYZ3Z6AksMIRtsQF jHF9hTvJOiefPZpxELDGYMJ6tAUmQIWljfR3T0AZNPEjTcmoKU8lI3UkBtJxU/Tw 355PM+QEo/6YQ+Lt9CJt/B10S0Kz1yYC7zhEwbf/yS+pJUQ9xO05HEab2UOKNU3g rmLE1KvDR/0PZbG3BMov/T29D6+SFN4lPbpCJNUjPQGXYdBGoyVCJsHWzyDsre6M bU6qNoiKqhh2ZbTDwmbg2I/3QNrQsysSY/3Y/LVT6PoiQAUfmBoeRNhxKbhbu7Wz qwTar1LUOnfTCA38AWuN/WqaZLZQpFk5LGDhFjHbAXC+jDyo/Mlbh+riMQ0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675507140; x=1675593540; bh=FcE/plgwiHcAVpfmlr0FqbcFN9q3 FpSWErJCt2r3sUY=; b=rcAdinM44pfyqTxPSfGahV4qzjI/uAtbtis9Ywvj6yS3 eowG1IkKQHNxby/somsvjLSR5DcXGtUR2qAQAlS2mnQz6vWvZh46MkyI3U5RdKqc ujXvDcSEiL6xIItuEXE1uFrDiO+7AJFj4dKSpvNIwUpSieA792RtWSFxFkT8bdm/ 3voGoLaLBxNpcmz9F2Uo63hoIvINeGTblbNHPsYF5ZuOzGePg7JvEAleq/HXcrlJ iuHueQcPKbRGBazaJMZ0Lku2hIPaP1EKobXZALvrASJWRFskRr5vWZ2VJ2kfuWj2 Lb/p28ItiAY8yZZXckajGloBwXGSSQ/2muK0/cET2g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegvddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1522EB60086; Sat, 4 Feb 2023 05:38:59 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-107-g82c3c54364-fm-20230131.002-g82c3c543 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Message-Id: In-Reply-To: <46dafb64-81d2-c084-97c5-8d01e8b9785b@infradead.org> References: <20230130130453.379749-1-arnd@kernel.org> <46dafb64-81d2-c084-97c5-8d01e8b9785b@infradead.org> Date: Sat, 04 Feb 2023 11:38:41 +0100 From: "Arnd Bergmann" To: "Randy Dunlap" , "Arnd Bergmann" , "Chen-Yu Tsai" , "Jernej Skrabec" , "Samuel Holland" , sparclinux Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: sunxi: select CONFIG_PM Content-Type: text/plain On Sat, Feb 4, 2023, at 08:47, Randy Dunlap wrote: > On 1/30/23 05:04, Arnd Bergmann wrote: > > Apparently sparc32 does not support PM (arch/sparc/Kconfig): > > if SPARC64 > source "kernel/power/Kconfig" > endif > > so I think that SUN20I_PPU should also depend on !SPARC32. > Does that make sense? I would suggest working around this in arch/sparc/ instead of every driver that uses 'select PM', perhaps something like --- a/arch/sparc/Kconfig +++ b/arch/sparc/Kconfig @@ -283,7 +283,7 @@ config ARCH_FORCE_MAX_ORDER This config option is actually maximum order plus one. For example, a value of 13 means that the largest free memory block is 2^12 pages. -if SPARC64 +if SPARC64 || COMPILE_TEST source "kernel/power/Kconfig" endif The issue does not happen anywhere else, as it's fine if kernel/power/Kconfig is not included at all. I'm also not too worried about random sparc32 configs since it's pretty much impossible to build a sparc32 allmodconfig or randconfig, with all the other bugs that runs into. Arnd