From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andre Przywara <andre.przywara@arm.com>,
Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev,
James McGregor <jamcgregor@protonmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: Add H616 compatible
Date: Tue, 23 Apr 2024 14:18:23 +0200 [thread overview]
Message-ID: <f2021c5d-25fa-4bdf-8f8c-b0bc271eb54e@linaro.org> (raw)
In-Reply-To: <20240423111502.6e068887@donnerap.manchester.arm.com>
On 23/04/2024 12:15, Andre Przywara wrote:
> On Mon, 22 Apr 2024 17:45:10 +0100
> Andre Przywara <andre.przywara@arm.com> wrote:
>
> Hi,
>
>> From: James McGregor <jamcgregor@protonmail.com>
>>
>> The Allwinner H616 SoC has an LRADC which is compatible with the
>> versions in existing SoCs.
>> Add a compatible string for H616, with the R329 fallback. This is the
>> same as the D1, so put them into an enum.
>>
>> Signed-off-by: James McGregor <jamcgregor@protonmail.com>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>
> Compared the descriptions in the manual between the R392 and the H616, they
> look the same:
>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Why do you review your own patches? Does it mean that you contribute
code which you did not review before?
This is odd process.
Your Review is implied by sending the patch. And you have there SoB
which indicates you sent it...
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-23 12:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 16:45 [PATCH 0/2] arm64: dts: allwinner: H616: Add LRADC Andre Przywara
2024-04-22 16:45 ` [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: Add H616 compatible Andre Przywara
2024-04-23 10:15 ` Andre Przywara
2024-04-23 12:18 ` Krzysztof Kozlowski [this message]
2024-04-23 12:51 ` Andre Przywara
2024-04-23 14:59 ` Krzysztof Kozlowski
2024-04-23 15:14 ` Krzysztof Kozlowski
2024-04-24 10:55 ` Andre Przywara
2024-04-24 17:56 ` Krzysztof Kozlowski
2024-04-23 14:32 ` Rob Herring
2024-04-22 16:45 ` [PATCH 2/2] arm64: dts: allwinner: h616: Add LRADC node Andre Przywara
2024-04-23 10:11 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2021c5d-25fa-4bdf-8f8c-b0bc271eb54e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jamcgregor@protonmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox