From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1A927F for ; Sun, 16 Oct 2022 17:51:54 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id c22so10211284lja.6 for ; Sun, 16 Oct 2022 10:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=FSvBiCYAFX6lPPhtdeLD4dtO79D7my2I84dZLy/XCHA=; b=ay7zBp6erCUcdx6FCqT2TK/HFdYqQN5L/xbUe1GlX5+3Crva5NM/VI5goKhyYCSDr/ C3a2cTjgiv2cwV9Jf5grm1XNi83lynnESdVLS/CAJWiYr4Kx+nAA8S7JVhdymP9samaF FxNpKzY+0hk83mw8X6eEOgPij9413yyZzcoRk1QpY0HS+li7n0fwtJe5SYxhABuK/CSB 5IchUWAz7SI+rV2710qacP4Zc4axHL432f76uZ0OERw0Zls5PqGWfywzmDCIO8Wod2Cm KMzbrnuvXRvglZ1oOjabABd/gR6IRbHjcHXuE5WxxNzxwMZ5ymInbJi7k2FNnw63GuOC 2jAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FSvBiCYAFX6lPPhtdeLD4dtO79D7my2I84dZLy/XCHA=; b=LIZmKRXAmXafa5mE2BM94aPxAOgYyQsQmH4VSH7vHu+NaS+0JR9DH8FaJeyTC2WKJH k/UZr3zBK1FYTMJg1qV9i24323MPJiZYATJIH9ThMbBPKQIvHc9fFT9lFs2dcLlL13oe rZ4SFL6Gt2UiuqJ+TPJNa3kv8ZmcLf6T2LfMOJufpgBqx+7Z68D7HW3fkSDlkPS+AE3k y+B/koiQaKnI/XkLdtxOMgicVuGnlHHM4+bmjl7rhJqIohsKMTPxWuX8PTA1U2bqCX0E NptZjf4xRmKwQKT2+CWL9Ly3mU9Ac/mxxL46tIfZj4Mjjcj4SUDVn/9XeK6D8/TygHgf 6bIg== X-Gm-Message-State: ACrzQf3zzoTd+n5IE6ssj/shzg9+pLfRSj0b6437Llyqm0EchH84PnsM SML/R1WWwOOzeDwQdN46B4E= X-Google-Smtp-Source: AMsMyM5LYmnlAPf1vl21rN/RrRZ7Perh4kso+zSaAUOKAYAg23YrPXCFUqcYyrDs9LnLqQm4wTNUeA== X-Received: by 2002:a2e:a7cc:0:b0:26f:cb7a:f375 with SMTP id x12-20020a2ea7cc000000b0026fcb7af375mr2869772ljp.392.1665942712788; Sun, 16 Oct 2022 10:51:52 -0700 (PDT) Received: from ?IPV6:2a02:a31a:a240:1700:64bb:87df:aad7:a9f0? ([2a02:a31a:a240:1700:64bb:87df:aad7:a9f0]) by smtp.googlemail.com with ESMTPSA id i4-20020a2ea364000000b0026dfedff58csm1205644ljn.99.2022.10.16.10.51.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Oct 2022 10:51:52 -0700 (PDT) From: Mateusz Kwiatkowski X-Google-Original-From: Mateusz Kwiatkowski Message-ID: Date: Sun, 16 Oct 2022 19:51:50 +0200 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Reply-To: kfyatek+publicgit@gmail.com Subject: Re: [PATCH v5 13/22] drm/modes: Introduce the tv_mode property as a command-line option Content-Language: pl To: Maxime Ripard , Karol Herbst , Jani Nikula , Tvrtko Ursulin , Daniel Vetter , Maarten Lankhorst , David Airlie , Joonas Lahtinen , Lyude Paul , Maxime Ripard , Emma Anholt , Chen-Yu Tsai , Samuel Holland , Ben Skeggs , Thomas Zimmermann , Rodrigo Vivi , Jernej Skrabec , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Cc: Dom Cobley , linux-sunxi@lists.linux.dev, Dave Stevenson , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Hans de Goede , Phil Elwell References: <20220728-rpi-analog-tv-properties-v5-0-d841cc64fe4b@cerno.tech> <20220728-rpi-analog-tv-properties-v5-13-d841cc64fe4b@cerno.tech> In-Reply-To: <20220728-rpi-analog-tv-properties-v5-13-d841cc64fe4b@cerno.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Maxime, Noralf & everyone, I'd like to address Noralf here in particular, and refer to these discussions from the past: - https://lore.kernel.org/linux-arm-kernel/2f607c7d-6da1-c8df-1c02-8dd344a92343@gmail.com/ - https://lore.kernel.org/linux-arm-kernel/9e76a508-f469-a54d-ecd7-b5868ca99af4@tronnes.org/ > @@ -2230,20 +2256,22 @@ struct drm_named_mode { > unsigned int xres; > unsigned int yres; > unsigned int flags; > + unsigned int tv_mode; > }; I saw that you (Noralf) opposed my suggestion about the DRM_MODE_TV_MODE_NONE enum value in enum drm drm_connector_tv_mode. I get your argumentation, and I'm not gonna argue, but I still don't like the fact that struct drm_named_mode now includes a field that is only relevant for analog TV modes, has no "none" value, and yet the type is supposed to be generic enough to be usable for other types of outputs as well. It's true that it can just be ignored (as Maxime mentioned in his response to my e-mail linked above), and now the value of 0 corresponds to DRM_MODE_TV_MODE_NTSC, which is a rather sane default, but it still feels messy to me. I'm not gonna force my opinion here, but I wanted to bring your attention to this issue, maybe you have some other solution in mind for this problem. Or if you don't see that as a problem at all, that's fine, too. Best regards, Mateusz Kwiatkowski