From: Sam Edwards <cfsworks@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>,
Jagan Teki <jagan@amarulasolutions.com>,
u-boot@lists.denx.de
Cc: Samuel Holland <samuel@sholland.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Icenowy Zheng <uwu@icenowy.me>,
Maxim Kiselev <bigunclemax@gmail.com>,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 03/20] pinctrl: sunxi: add GPIO in/out wrappers
Date: Wed, 9 Aug 2023 14:14:31 -0600 [thread overview]
Message-ID: <fffa623e-78ab-491b-dbfe-cde502014257@gmail.com> (raw)
In-Reply-To: <20230721134606.4505-4-andre.przywara@arm.com>
On 7/21/23 07:45, Andre Przywara wrote:
> So far we were open-coding the pincontroller's GPIO output/input access
> in each function using that.
>
> Provide functions that wrap that nicely, and follow the existing pattern
> (set/get_{bank,}), so users don't need to know about the internals, and
> we can abstract the new D1 pinctrl more easily.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Sam Edwards <CFSworks@gmail.com>
Tested-by: Sam Edwards <CFSworks@gmail.com>
Thanks,
Sam
next prev parent reply other threads:[~2023-08-09 20:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 13:45 [PATCH 00/20] sunxi: Allwinner T113s support Andre Przywara
2023-07-21 13:45 ` [PATCH 01/20] net: sunxi_emac: chase DT nodes to find PHY regulator Andre Przywara
2023-08-09 19:56 ` Sam Edwards
2023-07-21 13:45 ` [PATCH 02/20] sunxi: remove CONFIG_MACPWR Andre Przywara
2023-07-25 21:21 ` Sam Edwards
2023-07-26 13:52 ` Andre Przywara
2023-08-09 19:58 ` Sam Edwards
2023-07-21 13:45 ` [PATCH 03/20] pinctrl: sunxi: add GPIO in/out wrappers Andre Przywara
2023-08-09 20:14 ` Sam Edwards [this message]
2023-07-21 13:45 ` [PATCH 04/20] pinctrl: sunxi: remove struct sunxi_gpio Andre Przywara
2023-07-21 13:45 ` [PATCH 05/20] pinctrl: sunxi: move pinctrl code and remove GPIO_EXTRA_HEADER Andre Przywara
2023-07-21 13:45 ` [PATCH 06/20] pinctrl: sunxi: move PIO_BASE into sunxi_gpio.h Andre Przywara
2023-07-21 13:45 ` [PATCH 07/20] pinctrl: sunxi: add new D1 pinctrl support Andre Przywara
2023-08-09 22:04 ` Sam Edwards
2023-07-21 13:45 ` [PATCH 08/20] sunxi: introduce NCAT2 generation model Andre Przywara
2023-08-09 22:08 ` Sam Edwards
2023-09-27 9:42 ` Okhunjon Sobirjonov
2023-09-27 10:00 ` Andre Przywara
2023-07-21 13:45 ` [PATCH 09/20] pinctrl: sunxi: add Allwinner D1 pinctrl description Andre Przywara
2023-08-09 22:44 ` Sam Edwards
2023-07-21 13:45 ` [PATCH 10/20] clk: sunxi: Add support for the D1 CCU Andre Przywara
2023-07-21 13:45 ` [PATCH 11/20] sunxi: clock: D1/R528: Enable PLL LDO during PLL1 setup Andre Przywara
2023-07-21 13:45 ` [PATCH 12/20] sunxi: clock: support D1/R528 PLL6 clock Andre Przywara
2023-07-21 13:45 ` [PATCH 13/20] sunxi: clock: h6: prepare for PRCM less SoCs Andre Przywara
2023-07-21 13:46 ` [PATCH 14/20] Kconfig: sunxi: prepare for using drivers/ram/sunxi Andre Przywara
2023-07-21 13:46 ` [PATCH 15/20] sunxi: add R528/T113-s3/D1(s) DRAM initialisation code Andre Przywara
2023-07-28 3:35 ` Sam Edwards
2023-07-21 13:46 ` [PATCH 16/20] sunxi: add Allwinner R528/T113 SoC support Andre Przywara
2023-07-24 10:54 ` Maxim Kiselev
2023-07-21 13:46 ` [PATCH 17/20] sunxi: refactor serial base addresses to avoid asm/arch/cpu.h Andre Przywara
2023-07-21 13:46 ` [PATCH 18/20] riscv: dts: allwinner: Add the D1/D1s SoC devicetree Andre Przywara
2023-07-21 13:46 ` [PATCH 19/20] ARM: dts: sunxi: add Allwinner T113-s SoC .dtsi Andre Przywara
2023-08-09 22:34 ` Sam Edwards
2023-07-21 13:46 ` [PATCH 20/20] sunxi: add MangoPi MQ-R board support Andre Przywara
2023-07-26 23:47 ` [PATCH] sunxi: remove CONFIG_SATAPWR Andre Przywara
2023-07-27 0:08 ` Sam Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fffa623e-78ab-491b-dbfe-cde502014257@gmail.com \
--to=cfsworks@gmail.com \
--cc=andre.przywara@arm.com \
--cc=bigunclemax@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=u-boot@lists.denx.de \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).