Re: [PATCH 1/1] spi: use dmaengine_desc_set_callback()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] spi: rspi: missed desc_tx->callback conversion in rspi_dma_transfer()
--

commit fc7630df2ca55b14f36e688b27950bd8acaa67b6
Author: Frank Li <Frank.Li@nxp.com>

spi: use dmaengine_desc_set_callback()

This commit replaces open-coded assignments to the callback and
callback_param fields of struct dma_async_tx_descriptor with calls to
dmaengine_desc_set_callback() across SPI bus drivers in preparation for
making struct dma_async_tx_descriptor private to the DMA engine.

> diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c
> index c61edd1c1353b..5e03a186e9e79 100644
> --- a/drivers/spi/spi-rspi.c
> +++ b/drivers/spi/spi-rspi.c

[ ... ]

> @@ -577,8 +576,7 @@ static int rspi_dma_transfer(struct rspi_data *rspi, struct sg_table *tx,
>  			/* No callback */
>  			desc_tx->callback = NULL;
>  		} else {
> -			desc_tx->callback = rspi_dma_complete;
> -			desc_tx->callback_param = rspi;
> +			dmaengine_desc_set_callback(desc_tx, rspi_dma_complete, NULL, rspi);
>  		}

[Severity: Low]
In rspi_dma_transfer(), when both tx and rx scatter-gather tables are
present, the if (rx) branch right above the converted else branch still
directly assigns desc_tx->callback = NULL.

Should that branch also use dmaengine_desc_set_callback(desc_tx, NULL,
NULL, NULL) so that drivers/spi/spi-rspi.c does not fail to build when
struct dma_async_tx_descriptor is made private to the DMA engine?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102174005.3933649-1-Frank.Li@oss.nxp.com?part=1