From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794084490; b=TMiy7+sCuvZ4VcjmBCuUFsmAFwAHaL8bFHvOb5LsPzwsIOvUBO1PJdMbfuCKaqMS76Tv /X4ewOUL2u3IDD2v7x44EnX0xw62m6xflO360ZxD4MPvx9yblH7SpoZB4V8Pu1T/cLBFW 9SIHq+R6u+MR4IoHmXB8DLrUtFa8d0ZB/uaCFRCrdK5HUjVNCB29PEaCIcY7B8Cxg8UdD sxcU8Dkc556ErjvrmRg7KpThyEUJ0iwv32KU9Ylp/Ag+KR0Ve1iX78blKVUyIbxqGePgb dPcZ4/G8RgftW6N+fcUZ9puvUe7MmqQ/2p1Nyd/k+s1f2XJ1EbtvN3yxGRg5UW4BF2A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794084490; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=XiglxFtRswHRrbBgkGYgYBGQsVeSRteW99GaZhMNGiM=; b=T0qFpJjgvXHFR1Xak4cHQOKLDD/eSyXknvB2pkAnG9DyncoY54aI31nK6vLr7USGoUYa mUOLHRuJ7tsYS3fv6I+GtF3M59jnNJXMP2shMfJwHYk4c04mXFKi5bCWGMDIP2HGuiWa/ 0B4rlj/cTdjYJb48reCEa4xzKELw12KycDiBjF9tnka3KpG0pnKCGeIU1l6FlMMFoj54u utfPTq9/yakEAnupgHDlhVqOcMwYAwAlTbsO0/aflCNS0LXUAvrNy94DMi4V68w0nt8a3 zXg3E+tXE2o3kjss8Mu/wjfto1/R4qOgNyVQxG1WVaimM/rF6OtvZs46FIxZSE+wMrA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="OWje3/2R"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F053606A326; Sat, 7 Nov 2026 20:48:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=OWje3/2R Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A4921F0089F; Sat, 7 Nov 2026 20:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794084489; bh=XiglxFtRswHRrbBgkGYgYBGQsVeSRteW99GaZhMNGiM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=OWje3/2Rv7EJDS7J7WAZQ3IaKVBQIPUWgb0tHrXervawYZQjOzVkhShNBwmS1w0Ly NYzny1weZVmROwiM5tWc21yb3MqfhlxLsSki4pBb95h2faR0TLPOt33oizxPzqU42L qsZAMTfit6cvC1nImdFlId31OFqnsXb9MkcVL1pKkpy87MdgH/XuAF4ToOXabjsXGQ cF/aE3/+3UYQmxXLqYrzTKwinwq0GAropZvrRS5tFQphZKCI/yA+kvKt9ycqpqbdvI D6yWmoFemZW3fA01bwPsJbXw+8gocEUHNOnaBHmmuHh9sUcO/vZWR56WTIzSTM9uOx J0JnvKin7eX3Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 51/58] mtd: rawnand: mpc5121: retain chip state across removal Reply-To: sashiko-reviews@lists.linux.dev To: "James Hilliard" , "Miquel Raynal" , "Richard Weinberger" , "Vignesh Raghavendra" , "Brian Norris" , "Boris Brezillon" , "Arseniy Krasnov" , "Chen-Yu Tsai" , "Jernej Skrabec" , "Samuel Holland" , "Thomas Gleixner" , "Vitaly Wool" , "David Woodhouse" , "Russell King" , "David Woodhouse" , "Mike Rapoport" , "Maxime Coquelin" , "Alexandre Torgue" , "Christophe Kerello" , "Jason Roberts" , "Michal Simek" , "Boris Brezillon" , "Mason Yang" , "Ramuthevar Vadivel Murugan" , "Stefan Agner" , "Lucas Stach" , "Thierry Reding" , "Jonathan Hunter" , "Dmitry Osipenko" , "Matthias Brugger" , "AngeloGioacchino Del Regno" , "Jorge Ramirez-Ortiz" , "Heiko Stuebner" , "Yifeng Zhao" , "Nicolas Ferre" , "Alexandre Belloni" , "Claudiu Beznea" , "Keguang Zhang" , "Jacky Huang" , "Shan-Chun Hung" , "Frank Li" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Han Xu" , "Liang Yang" , "Neil Armstrong" , "Kevin Hilman" , "Jerome Brunet" , "Martin Blumenstingl" , "Manivannan Sadhasivam" , "Kamal Dasu" , "Broadcom internal kernel review list" , "Vladimir Zapolskiy" , "Piotr Wojtaszczyk" , "Paul Cercueil" , "Harvey Hunt" , "Maxim Levitsky" , "Michael Walle" , "Srinivas Kandagatla" Cc: "Tze Yee Ng" , linux-mtd@lists.infradead.org, linux-sunxi@lists.linux.dev, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, Frank.Li@kernel.org, wsa+renesas@sang-engineering.com In-Reply-To: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-51-0181ef0cc4c8@gmail.com> References: <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com> <20261107-submit-rawnand-retained-handle-lifetime-v1-v1-51-0181ef0cc4c8@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 07 Nov 2026 20:48:02 +0000 X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] mtd: rawnand: mpc5121: missing Fixes trailer for probe leak and removal UAF -- commit 648cd21cc2eac3c4001033a11e9ac4de646c25b6 Author: James Hilliard > mtd: rawnand: mpc5121: retain chip state across removal > > Drain NAND access before unmapping the external chip-select registers. > Keep the embedded chip and controller alive until the final MTD > reference, and unwind scanned NAND state on unsupported geometry and > publication failure. > > Signed-off-by: James Hilliard [Severity: Low] This fixes a probe-time leak of nand_scan() allocations and a use-after-free on device removal while MTD handles remain open, both present since the driver was added. Should it include a Fixes: tag? Fixes: bb315f749f8c ("mtd: nand: Add MPC5121 NAND Flash Controller driver= ") --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261107-submit-raw= nand-retained-handle-lifetime-v1-v1-0-0181ef0cc4c8@gmail.com?part=3D51