Re: [PATCH 3/8] arm64: dts: allwinner: h616: Add GPU OPP table

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: allwinner: h616: GPU OPP triplets set min voltage
  below target
--

commit 77493b95bc2bf6851fa12081534ceeb124aa8295
Author: Arun Iyengar <aiyengar1990@gmail.com>

arm64: dts: allwinner: h616: Add GPU OPP table

This commit adds a shared GPU operating points table for the Allwinner
H616/H618 Mali-G31 GPU covering 306 MHz to 600 MHz.

> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-gpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616-gpu-opp.dtsi
> new file mode 100644
> index 0000000000000..511174eee271b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-gpu-opp.dtsi
> @@ -0,0 +1,62 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +// Copyright (C) 2026 Arun Iyengar <aiyengar1990@gmail.com>
> +
> +/ {
> +	gpu_opp_table: opp-table-gpu {
> +		compatible = "operating-points-v2";
> +
> +		opp-306000000 {
> +			opp-hz = /bits/ 64 <306000000>;
> +			opp-microvolt = <810000 810000 990000>;
> +		};
> +
> +		opp-336000000 {
> +			opp-hz = /bits/ 64 <336000000>;
> +			opp-microvolt = <810000 810000 990000>;
> +		};
> +
> +		opp-360000000 {
> +			opp-hz = /bits/ 64 <360000000>;
> +			opp-microvolt = <820000 810000 990000>;
> +		};
> +
> +		opp-384000000 {
> +			opp-hz = /bits/ 64 <384000000>;
> +			opp-microvolt = <830000 810000 990000>;
> +		};
> +
> +		opp-420000000 {
> +			opp-hz = /bits/ 64 <420000000>;
> +			opp-microvolt = <850000 810000 990000>;
> +		};
> +
> +		opp-456000000 {
> +			opp-hz = /bits/ 64 <456000000>;
> +			opp-microvolt = <870000 810000 990000>;
> +		};
> +
> +		opp-504000000 {
> +			opp-hz = /bits/ 64 <504000000>;
> +			opp-microvolt = <890000 810000 990000>;
> +		};
> +
> +		opp-540000000 {
> +			opp-hz = /bits/ 64 <540000000>;
> +			opp-microvolt = <910000 810000 990000>;
> +		};
> +
> +		opp-576000000 {
> +			opp-hz = /bits/ 64 <576000000>;
> +			opp-microvolt = <930000 810000 990000>;
> +		};
> +
> +		opp-600000000 {
> +			opp-hz = /bits/ 64 <600000000>;
> +			opp-microvolt = <950000 810000 990000>;
> +		};

[Severity: Medium]
Should the minimum voltage in opp-microvolt match the target voltage on
opp-360000000 through opp-600000000, as in sun50i-h6-gpu-opp.dtsi?

opp_parse_supplies() parses a 3-cell opp-microvolt as <target min max>.
_opp_supported_by_regulators() checks regulator_is_supported_voltage()
against [u_volt_min, u_volt_max], and regulator_set_voltage_triplet()
falls back to [min_uV, max_uV] when [target_uV, max_uV] fails.

Keeping min at 810000 uV lets boards whose GPU supply maximum is below
950 mV retain higher-frequency OPPs and run them up to 600 MHz while
undervolted below their target voltage.  Setting <target target 990000>
still lets boards with a higher regulator-min-microvolt use lower OPPs,
since [target, 990000] overlaps the regulator range and
regulator_check_voltage() clamps min_uV up to the supply's minimum.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-h616-zero2-dt-v1-0-05506d760f21@gmail.com?part=3