Re: [PATCH net-next 1/2] net: stmmac: dwmac-sun8i: Fix the RX_TH threshold encoding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] net: stmmac: dwmac-sun8i: missing Fixes tag and inaccurate
  commit msg
--

commit bc43819b000accd77627647d6f7f32c68d0bcbe3
Author: Arun Iyengar <aiyengar1990@gmail.com>

> net: stmmac: dwmac-sun8i: Fix the RX_TH threshold encoding
>
> The EMAC RX_CTL1 RX_TH field (bits 5:4) encodes 00 = 64 bytes and
> 01 = 32 bytes (H616 user manual v1.0, 6.5.10; 10 = 96 and 11 = 128 bytes
> as in the driver). The driver has the first two swapped.
>
> The values are only used in RX threshold mode, which dwmac-sun8i never
> selects while RX checksum offload is on, so no current configuration is
> affected.
>
> Signed-off-by: Arun Iyengar <aiyengar1990@gmail.com>

[Severity: Low]
Since this fixes the swapped EMAC_RX_TH_32 and EMAC_RX_TH_64 definitions from
the initial driver commit, should it include:

  Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")

Also, is the explanation about RX checksum offload accurate?
stmmac_dma_operation_mode() and stmmac_bump_dma_threshold() only select RX
threshold mode when priv->plat->force_thresh_dma_mode is set and use
SF_DMA_MODE otherwise, independent of priv->plat->rx_coe.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-sun8i-emac-jumbo-v1-0-84bf00e9ffa3@gmail.com?part=1