From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@kernel.org>
Cc: Mikko Perttunen <mperttunen@nvidia.com>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] drm/tegra: Add blend mode properties
Date: Thu, 27 Aug 2026 10:23:28 +0100 [thread overview]
Message-ID: <043ffecd-22d1-4bfc-ac25-b95118471972@nvidia.com> (raw)
In-Reply-To: <20260826105421.1825331-1-thierry.reding@kernel.org>
On 26/08/2026 11:54, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The default programming in the driver matches the "coverage" blend mode,
> so add the corresponding pixel blend mode property to let userspace know
> about it.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/gpu/drm/tegra/dc.c | 6 ++++++
> drivers/gpu/drm/tegra/hub.c | 2 ++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
> index 0b3fcc7011b35..fefc3761a4bc7 100644
> --- a/drivers/gpu/drm/tegra/dc.c
> +++ b/drivers/gpu/drm/tegra/dc.c
> @@ -904,6 +904,7 @@ static struct drm_plane *tegra_primary_plane_create(struct drm_device *drm,
> struct tegra_dc *dc)
> {
> unsigned long possible_crtcs = tegra_plane_get_possible_crtcs(drm);
> + unsigned int blend_caps = BIT(DRM_MODE_BLEND_COVERAGE);
> enum drm_plane_type type = DRM_PLANE_TYPE_PRIMARY;
> struct tegra_plane *plane;
> unsigned int num_formats;
> @@ -939,6 +940,7 @@ static struct drm_plane *tegra_primary_plane_create(struct drm_device *drm,
> }
>
> drm_plane_helper_add(&plane->base, &tegra_plane_helper_funcs);
> + drm_plane_create_blend_mode_property(&plane->base, blend_caps);
> drm_plane_create_zpos_property(&plane->base, plane->index, 0, 255);
>
> err = drm_plane_create_rotation_property(&plane->base,
> @@ -1209,6 +1211,7 @@ static struct drm_plane *tegra_dc_cursor_plane_create(struct drm_device *drm,
> struct tegra_dc *dc)
> {
> unsigned long possible_crtcs = tegra_plane_get_possible_crtcs(drm);
> + unsigned int blend_caps = BIT(DRM_MODE_BLEND_COVERAGE);
> struct tegra_plane *plane;
> unsigned int num_formats;
> const u32 *formats;
> @@ -1252,6 +1255,7 @@ static struct drm_plane *tegra_dc_cursor_plane_create(struct drm_device *drm,
> }
>
> drm_plane_helper_add(&plane->base, &tegra_cursor_plane_helper_funcs);
> + drm_plane_create_blend_mode_property(&plane->base, blend_caps);
> drm_plane_create_zpos_immutable_property(&plane->base, 255);
>
> return &plane->base;
> @@ -1356,6 +1360,7 @@ static struct drm_plane *tegra_dc_overlay_plane_create(struct drm_device *drm,
> bool cursor)
> {
> unsigned long possible_crtcs = tegra_plane_get_possible_crtcs(drm);
> + unsigned int blend_caps = BIT(DRM_MODE_BLEND_COVERAGE);
> struct tegra_plane *plane;
> unsigned int num_formats;
> enum drm_plane_type type;
> @@ -1394,6 +1399,7 @@ static struct drm_plane *tegra_dc_overlay_plane_create(struct drm_device *drm,
> }
>
> drm_plane_helper_add(&plane->base, &tegra_plane_helper_funcs);
> + drm_plane_create_blend_mode_property(&plane->base, blend_caps);
> drm_plane_create_zpos_property(&plane->base, plane->index, 0, 255);
>
> err = drm_plane_create_rotation_property(&plane->base,
> diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
> index bd442bfd45407..448f49f3a7d7e 100644
> --- a/drivers/gpu/drm/tegra/hub.c
> +++ b/drivers/gpu/drm/tegra/hub.c
> @@ -759,6 +759,7 @@ struct drm_plane *tegra_shared_plane_create(struct drm_device *drm,
> unsigned int index,
> enum drm_plane_type type)
> {
> + unsigned int blend_caps = BIT(DRM_MODE_BLEND_COVERAGE);
> struct tegra_drm *tegra = drm->dev_private;
> struct tegra_display_hub *hub = tegra->hub;
> struct tegra_shared_plane *plane;
> @@ -797,6 +798,7 @@ struct drm_plane *tegra_shared_plane_create(struct drm_device *drm,
> }
>
> drm_plane_helper_add(p, &tegra_shared_plane_helper_funcs);
> + drm_plane_create_blend_mode_property(p, blend_caps);
> drm_plane_create_zpos_property(p, 0, 0, 255);
>
> return p;
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Thanks!
Jon
--
nvpublic
prev parent reply other threads:[~2026-08-27 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 10:54 [PATCH] drm/tegra: Add blend mode properties Thierry Reding
2026-08-27 9:23 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=043ffecd-22d1-4bfc-ac25-b95118471972@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox