From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB2FC433F5 for ; Wed, 30 Mar 2022 00:07:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240597AbiC3AIt (ORCPT ); Tue, 29 Mar 2022 20:08:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232984AbiC3AIs (ORCPT ); Tue, 29 Mar 2022 20:08:48 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA4B943483; Tue, 29 Mar 2022 17:07:04 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 970AC1F439F1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1648598823; bh=dRavRYMt4OXmhvAe8PF9ABx9qq8MFHZ3LSwNhkacwkE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hh+IQsoK7zvHgnfGfROXkPwo6+B/Do7vmAiYuC7Tr1odb20mC9vKiTdnvuUlO+ALx Xy8vbDrdwHf3icILpszpILr+q/QJQOi1E2W8dKrhXZFypLtudxx6vda6dxU0Jemasu uR67nsFC7NzvXkQk7sI9gWvCga9b1MJdTJ+tS0TEftojx4SO/scHMBfhtH7CRFbavU I4ucJeC+hNVAU4R3ALFMNt4LeUuBPNH8dSjG+yT+1q9pi0j4r0bCZmfXKRjSSJu5UX PSpow83MQP2LMDDEriKj7NWEhh6DlYy6uo4GmvajJtwHrtJEfYoJIdp7S+zAuyndWs NRGBATme8EXeA== Message-ID: <04bb5ef2-15c3-d561-3572-76dc803275ef@collabora.com> Date: Wed, 30 Mar 2022 03:06:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [Patch v5 2/4] memory: tegra: Add MC error logging on tegra186 onward Content-Language: en-US To: Ashish Mhetre , krzysztof.kozlowski@canonical.com, robh+dt@kernel.org, thierry.reding@gmail.com, digetx@gmail.com, jonathanh@nvidia.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org Cc: vdumpa@nvidia.com, Snikam@nvidia.com References: <20220316092525.4554-1-amhetre@nvidia.com> <20220316092525.4554-3-amhetre@nvidia.com> From: Dmitry Osipenko In-Reply-To: <20220316092525.4554-3-amhetre@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 3/16/22 12:25, Ashish Mhetre wrote: > Add new function 'get_int_channel' in tegra_mc_soc struture which is > implemented by tegra SOCs which support multiple MC channels. This > function returns the channel which should be used to get the information > of interrupts. > Remove static from tegra30_mc_handle_irq and use it as interrupt handler > for MC interrupts on tegra186, tegra194 and tegra234 to log the errors. > Add error specific MC status and address register bits and use them on > tegra186, tegra194 and tegra234. > Add error logging for generalized carveout interrupt on tegra186, tegra194 > and tegra234. > Add error logging for route sanity interrupt on tegra194 an tegra234. > Add register for higher bits of error address which is available on > tegra194 and tegra234. > Add a boolean variable 'has_addr_hi_reg' in tegra_mc_soc struture which > will be true if soc has register for higher bits of memory controller > error address. Set it true for tegra194 and tegra234. > > Signed-off-by: Ashish Mhetre > Reported-by: kernel test robot > Reported-by: Dan Carpenter Reported what? You should add this tag only if patch addresses reported problem. This patch doesn't address anything, hence the tag is inappropriate, you should remove it.