From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9629880614 for ; Wed, 17 Apr 2024 08:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713342991; cv=none; b=f05dT+Mpci0tP+u34z5YnZ+iz2BEd50WVGfHg7qPU8XI9WP6dzscicL6iYe0BOk9dVms+wQpoIbztHOaDcvYFsEArEDO4b6HdYgZOZJNi+Wd32AbQoY9Q3eTYZ9ZudnjAMopJWL6dYYb6/cV8/uCt13cgT48WaAJuR7D0QlHaE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713342991; c=relaxed/simple; bh=jLrSv3mDwVJf7c0urmHft4NujHyUwpP7/8/epSXi7WY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B4aXBb92PcshUsDHtwk4Sqp8jzlJCs8Kha+a0D7xOh4lJ2X5B7LW6gx00wExTWNJ600Ahl43ArljR4CXF5l7dhCT9+TruR50BYBJwJfCJREQa14H0CfZFPw2Er2kK/k7mihLUENar8pSRdYdtofHd8w6LikoOUt18qP57Sb1Nn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=t7Q6Ct7S; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t7Q6Ct7S" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-56fd7df9ea9so6230421a12.0 for ; Wed, 17 Apr 2024 01:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713342988; x=1713947788; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iQiui35tGbgrLHrxJlWNcYO7KRQh2YZtezQ4w5QZix0=; b=t7Q6Ct7S2/PJ0C1gD6abhxeDvZGAZmkQHqgYIfIA+Wpu5qwYOqSKjTWPOMd+KaqfNI iuXCtg1wbAFy3ODG13QBvTtg+Ijmi9OEQEOHCT8PqEQ8iC9jLFW7z9RaTZVwtap0QF+5 Ckoy82ZCaSERUWFyhGjHgjBblrHVQ7GzasKMq2Mzy5vExx7ogT9OLhedEsUSubIaxV/z n+/Hh8P5DrqqOtbtkW/XVCIYBuPT2WIl3EeESLpBjPXah+tOwugMuPcD8qwFYhgrImfc hQH7Z7T+EgikKiN5y0/uO/gU6hZSvvGX9I3sArmsyXLynRU/mSYizP23syqIBNGb1zmp +CAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713342988; x=1713947788; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iQiui35tGbgrLHrxJlWNcYO7KRQh2YZtezQ4w5QZix0=; b=kHzWGrpd6ivR7ot9WkZFryWBxbD1AfpVEumoRjYKC8dpyWxweCME3wari/96nRe1FM t/Alukyag0GiJRjoFv6pEECG46rXKLmu+kVHkxWtjIrj0lTYUuZr33Lk6ggG6L+DqY5P vraRkDar0d1QjzEFDZOKuNdSmr3rCCv8y0FPhW+uuMrH8XgXGz0PepE9iyYdDWB8cbg5 fz9+RQR2a3dpbdmp26nFssWD9hqSF3txTv9YOpPZKfR0pf2DhTGZhI4u5XPtvwJMOx46 G/204to6EWfBWUoZj6SGAuDUAJFPkMzyqx4sjm0GN1nuvhtIM3hO33+ZMB6rLZaO33Hc xGDw== X-Forwarded-Encrypted: i=1; AJvYcCWN1oDVJxIV0y6haKu7v8f8uChGbkZjKoFcd2fDG5vM+TMAz4VHKkfS6J+T1/d7VG8Qy+zMG5GjzMUB8q+P72xUixtOLiEAuFzACEM= X-Gm-Message-State: AOJu0YwwZ6EwAkUUESRcY0qpdF3TKelvmonhIosBwUTr98XElhjLxoVM SDCRmqnkdTO024UZ0tgwbEYZ+GJ5eBhHMHgz8eLC555VpFAB+DTl19t6VneLghc= X-Google-Smtp-Source: AGHT+IGcBOrF6dlMwP4LWwT62iTJu3n3+RD0VmgZxc7ueD6NugKm/u+kb1GXFPPYn+h8dHTWajk2Vg== X-Received: by 2002:a17:907:846:b0:a52:6fcb:564a with SMTP id ww6-20020a170907084600b00a526fcb564amr5823920ejb.9.1713342987569; Wed, 17 Apr 2024 01:36:27 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id cw21-20020a170906479500b00a52182471a2sm7905680ejc.13.2024.04.17.01.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 01:36:27 -0700 (PDT) Date: Wed, 17 Apr 2024 11:36:23 +0300 From: Dan Carpenter To: Ricardo Ribalda Cc: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 25/35] media: venus: Use the correct div_ function Message-ID: <06113ffe-11bd-4c73-aff7-5e55aa8e3edc@moroto.mountain> References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-25-477afb23728b@chromium.org> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415-fix-cocci-v1-25-477afb23728b@chromium.org> On Mon, Apr 15, 2024 at 07:34:42PM +0000, Ricardo Ribalda wrote: > us_per_frame does not fit in u32 > drivers/media/platform/qcom/venus/venc.c 391 static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a) 392 { 393 struct venus_inst *inst = to_inst(file); 394 struct v4l2_outputparm *out = &a->parm.output; 395 struct v4l2_fract *timeperframe = &out->timeperframe; 396 u64 us_per_frame, fps; 397 398 if (a->type != V4L2_BUF_TYPE_VIDEO_OUTPUT && 399 a->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) 400 return -EINVAL; 401 402 memset(out->reserved, 0, sizeof(out->reserved)); 403 404 if (!timeperframe->denominator) 405 timeperframe->denominator = inst->timeperframe.denominator; 406 if (!timeperframe->numerator) 407 timeperframe->numerator = inst->timeperframe.numerator; 408 409 out->capability = V4L2_CAP_TIMEPERFRAME; 410 411 us_per_frame = timeperframe->numerator * (u64)USEC_PER_SEC; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ It looks like in some drivers this multiply can go over U32_MAX. 412 do_div(us_per_frame, timeperframe->denominator); ^^^^^^^^^^^^ But after this divide, then we're under 1,000,000 again. Otherwise the FPS is zero. So maybe the right thing to do is: inst->fps = USEC_PER_SEC / (u32)us_per_frame; 413 414 if (!us_per_frame) 415 return -EINVAL; 416 417 fps = (u64)USEC_PER_SEC; 418 do_div(fps, us_per_frame); 419 420 inst->timeperframe = *timeperframe; 421 inst->fps = fps; 422 423 return 0; 424 } regards, dan carpenter