From: Dmitry Osipenko <digetx@gmail.com>
To: Mikko Perttunen <mperttunen@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com
Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] gpu: host1x: Improve debug disassembly formatting
Date: Sat, 19 Aug 2017 00:54:50 +0300 [thread overview]
Message-ID: <0864cb4f-93b4-522f-bf0e-27be75a5b1d5@gmail.com> (raw)
In-Reply-To: <20170818161553.27597-4-mperttunen@nvidia.com>
On 18.08.2017 19:15, Mikko Perttunen wrote:
> The host1x driver prints out "disassembly" dumps of the command FIFO
> and gather contents on submission timeouts. However, the output has
> been quite difficult to read with unnecessary newlines and occasional
> missing parentheses.
>
> Fix these problems by using pr_cont to remove unnecessary newlines
> and by fixing other small issues.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
It's indeed a bit more readable now.
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
--
Dmitry
next prev parent reply other threads:[~2017-08-18 21:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 16:15 [PATCH 0/4] Miscellaneous improvements to Host1x and TegraDRM Mikko Perttunen
2017-08-18 16:15 ` [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection Mikko Perttunen
[not found] ` <20170818161553.27597-2-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-08-18 22:36 ` Dmitry Osipenko
[not found] ` <d6d10aec-3d2a-99b3-a23d-41147478f412-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-19 8:10 ` Mikko Perttunen
[not found] ` <5ff98485-e8ac-75e0-ca8f-3887f8593ec4-/1wQRMveznE@public.gmane.org>
2017-08-19 10:09 ` Dmitry Osipenko
2017-08-19 10:35 ` Mikko Perttunen
[not found] ` <6979443e-ad2b-1da6-f71c-61913242f257-/1wQRMveznE@public.gmane.org>
2017-08-19 11:11 ` Dmitry Osipenko
[not found] ` <ed7f2987-062a-fa53-6243-bd81a600e96e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-19 11:32 ` Mikko Perttunen
[not found] ` <72fc513b-2626-fd86-1b98-5d2f8e89dc5f-/1wQRMveznE@public.gmane.org>
2017-08-19 11:51 ` Dmitry Osipenko
2017-08-19 12:02 ` Dmitry Osipenko
2017-08-20 16:18 ` Dmitry Osipenko
2017-08-20 16:59 ` Dmitry Osipenko
2017-08-20 18:13 ` Dmitry Osipenko
2017-08-18 16:15 ` [PATCH 2/4] gpu: host1x: Enable gather filter Mikko Perttunen
[not found] ` <20170818161553.27597-3-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-08-19 10:42 ` Dmitry Osipenko
[not found] ` <ae084d08-89d0-ced0-c040-78500aa8e5d5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-19 10:46 ` Mikko Perttunen
[not found] ` <64de3b3b-7c9e-54e9-49f4-d89b3d2c5f21-/1wQRMveznE@public.gmane.org>
2017-08-19 12:05 ` Dmitry Osipenko
2017-08-20 16:24 ` Dmitry Osipenko
[not found] ` <78e11be6-1e4f-18e0-cdc0-13db4bf57bf6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-20 16:44 ` Dmitry Osipenko
2017-08-20 16:59 ` Dmitry Osipenko
[not found] ` <f42a2854-d70c-ef40-7d45-ec14f581c337-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-21 17:27 ` Mikko Perttunen
2017-08-21 17:28 ` Mikko Perttunen
2017-08-18 16:15 ` [PATCH 3/4] gpu: host1x: Improve debug disassembly formatting Mikko Perttunen
2017-08-18 21:54 ` Dmitry Osipenko [this message]
2017-08-18 16:15 ` [PATCH 4/4] drm/tegra: Use u64_to_user_ptr helper Mikko Perttunen
[not found] ` <20170818161553.27597-5-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-08-18 22:05 ` Dmitry Osipenko
[not found] ` <f16347d6-991e-4d61-eb55-cca24bcf5625-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-19 8:06 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0864cb4f-93b4-522f-bf0e-27be75a5b1d5@gmail.com \
--to=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox