Re: [PATCH v5 1/4] dt-bindings: rtc: Document NVIDIA VRS RTC

[Jon Hunter <jonathanh@nvidia.com>]

On 24/07/2025 11:06, Krzysztof Kozlowski wrote:
> On 24/07/2025 11:41, Jon Hunter wrote:
>>
>> On 24/07/2025 08:59, Krzysztof Kozlowski wrote:
>>> On Wed, Jul 23, 2025 at 01:03:40PM +0000, Shubhi Garg wrote:
>>>> +description:
>>>> +  NVIDIA VRS (Voltage Regulator Specification) RTC provides 32kHz RTC clock
>>>> +  support with backup battery for system timing. It provides alarm functionality
>>>> +  to wake system from suspend and shutdown state. The device also acts as an
>>>> +  interrupt controller for managing interrupts from the VRS.
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    const: nvidia,vrs10-rtc
>>>
>>> Nothing improved. You never replied to comments and then replaced one
>>> redundant word into other redundant word.
>>>
>>> Respond to review or implement it fully, not partially.
>>>
>>> Or add COMPLETE bindings, not partial ones. See writing bindings doc.
>>
>> OK, right so the DT binding should describe the overall PMIC device,
>> even though the driver needs to support the RTC.
> 
> 
> This is not a driver patch. This is patch for hardware. Sending
> incomplete pieces of a device, without complete picture is really not
> the right way. Knowing this is part of PMIC this should be rejected, but
> how can we decide on that if contributor never tells us this is a part
> of PMIC?

Yes I understand that this is not a driver patch and must describe the 
hardware. It is a simple misunderstanding because it was rejected as an 
MFD, but we should not have then made the DT look like only a RTC 
device. This is a mistake on our side and we will fix.

Jon

-- 
nvpublic