From: Chanwoo Choi <cw00.choi@samsung.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PM / devfreq: tegra30: disable clock on error in probe
Date: Wed, 23 Sep 2020 09:42:12 +0900 [thread overview]
Message-ID: <10303589-a40d-f295-e35e-5c2cf6c8f2e0@samsung.com> (raw)
In-Reply-To: <cc3523ad-1295-cccb-12da-f0ea7c129e7a@gmail.com>
On 9/23/20 9:23 AM, Dmitry Osipenko wrote:
> 21.09.2020 00:37, Dmitry Osipenko пишет:
>> 18.09.2020 12:23, Chanwoo Choi пишет:
>> ...
>>>> Hence if we want to improve the code, I think we can make this change:
>>>>
>>>> diff --git a/drivers/devfreq/tegra30-devfreq.c
>>>> b/drivers/devfreq/tegra30-devfreq.c
>>>> index ee274daa57ac..4e3ac23e6850 100644
>>>> --- a/drivers/devfreq/tegra30-devfreq.c
>>>> +++ b/drivers/devfreq/tegra30-devfreq.c
>>>> @@ -891,8 +891,6 @@ static int tegra_devfreq_probe(struct
>>>> platform_device *pdev)
>>>> return err;
>>>> }
>>>>
>>>> - reset_control_assert(tegra->reset);
>>>> -
>>>> err = clk_prepare_enable(tegra->clock);
>>>> if (err) {
>>>> dev_err(&pdev->dev,
>>>> @@ -900,7 +898,7 @@ static int tegra_devfreq_probe(struct
>>>> platform_device *pdev)
>>>> return err;
>>>> }
>>>>
>>>> - reset_control_deassert(tegra->reset);
>>>> + reset_control_reset(tegra->reset);
>>>>
>>>> for (i = 0; i < mc->num_timings; i++) {
>>>> /*
>>>
>>> It looks good to me for improving the readability
>>> for everyone who don't know the detailed h/w information.
>>
>> Okay, I'll make a patch sometime soon.
>
> Chanwoo, I want to clarify that the Dan's v1 patch is still good to me
> and should be applied. I'll improve the readability on top of the Dan's
> change.
>
>
OK. Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2020-09-23 0:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200908072627epcas1p41f2c8c2730d42bd8935a40b0ab8122f7@epcas1p4.samsung.com>
2020-09-08 7:25 ` [PATCH] PM / devfreq: tegra30: disable clock on error in probe Dan Carpenter
2020-09-08 13:02 ` Dmitry Osipenko
2020-09-14 7:09 ` Chanwoo Choi
2020-09-14 13:56 ` Dmitry Osipenko
2020-09-14 14:17 ` Dan Carpenter
2020-09-14 14:28 ` Dmitry Osipenko
2020-09-15 2:00 ` Chanwoo Choi
2020-09-15 2:13 ` Chanwoo Choi
2020-09-15 17:01 ` Dmitry Osipenko
2020-09-16 2:38 ` Chanwoo Choi
2020-09-16 19:07 ` Dmitry Osipenko
2020-09-17 2:32 ` Chanwoo Choi
2020-09-17 21:14 ` Dmitry Osipenko
2020-09-18 9:23 ` Chanwoo Choi
2020-09-20 21:37 ` Dmitry Osipenko
2020-09-23 0:23 ` Dmitry Osipenko
2020-09-23 0:42 ` Chanwoo Choi [this message]
2020-09-14 13:57 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10303589-a40d-f295-e35e-5c2cf6c8f2e0@samsung.com \
--to=cw00.choi@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox