From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH] dmaengine: tegra210-adma: handle pm_runtime_get_sync failure cases Date: Fri, 5 Jun 2020 06:56:13 +0100 Message-ID: <103127de-ff57-d033-5794-71effc032e9a@nvidia.com> References: <20200604201058.86457-1-navid.emamdoost@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200604201058.86457-1-navid.emamdoost-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Navid Emamdoost , Laxman Dewangan , Dan Williams , Vinod Koul , Thierry Reding , dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: emamd001-OJFnDUYgAso@public.gmane.org, wu000273-OJFnDUYgAso@public.gmane.org, kjlu-OJFnDUYgAso@public.gmane.org, mccamant-k0Ej6N9cQa43uPMLIKxrzw@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 04/06/2020 21:10, Navid Emamdoost wrote: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put if > pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost > --- > drivers/dma/tegra210-adma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c > index c4ce5dfb149b..899eaaf9fc48 100644 > --- a/drivers/dma/tegra210-adma.c > +++ b/drivers/dma/tegra210-adma.c > @@ -659,6 +659,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) > ret = pm_runtime_get_sync(tdc2dev(tdc)); > if (ret < 0) { > free_irq(tdc->irq, tdc); > + pm_runtime_put(tdc2dev(tdc)); > return ret; > } > > @@ -870,7 +871,7 @@ static int tegra_adma_probe(struct platform_device *pdev) > > ret = pm_runtime_get_sync(&pdev->dev); > if (ret < 0) > - goto rpm_disable; > + goto rpm_put; > > ret = tegra_adma_init(tdma); > if (ret) > The label rpm_disable should now be removed. You should also update the subject-prefix to be [PATCH V2] to make it clear that this is the updated patch. Jon -- nvpublic