From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 088EAC0015E for ; Tue, 11 Jul 2023 10:09:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230292AbjGKKJd (ORCPT ); Tue, 11 Jul 2023 06:09:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229837AbjGKKJc (ORCPT ); Tue, 11 Jul 2023 06:09:32 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFB5310A for ; Tue, 11 Jul 2023 03:09:30 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4fafe87c6fbso8721767e87.3 for ; Tue, 11 Jul 2023 03:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689070169; x=1691662169; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7dRYhDe8BiVEV0EBlHbMEnxi5wvB4qWMFbFVB8lXRts=; b=aFgnj794CZ/PSLsUzrOXSBGzhI4B7HswMutmsFqschHSz8cORA+/pDetACQMnLtiVf SmrzCFCT/cs+yM6BikKD/fqtRXullzc+RV31vTmrAL7rMnzI7g16FM72t2KqZivXVtiL fMRV7ruLnrIMLDcjsLJWEglSNQS1EXdKxUdtJ7xeV2OpYxq6LtL3o6/GCUCTxNGksEAq OaXuZwr3JCMIQ1l/iQaAsAXZe5TMsMdztIpr3EeEXtf9nprw/1zwlBw+P4lNXSRt+M6k rXc9W4f0n7upozPz3dJJtgCxGq6YYdfg3Q3boXohjB+hDA1PLH4SmzjbP61YS/E3XkvU pJlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689070169; x=1691662169; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7dRYhDe8BiVEV0EBlHbMEnxi5wvB4qWMFbFVB8lXRts=; b=LifypKq59o8c5b60snp59Dk4KXVssUh+9dU4i0pKUPETMXMNOLd5kYY5jInI3cbMA9 /CeisWAY5opoX9HtwF5YbggC7/WpZaR9Iti9h3OkOwmcyoAbmlXt1TTqEOEKCU/9QYTJ +fcUdVyA6OhIwfU/4Ew6TBT0tvJG9/BJiW0dIXtRZXdtB744109bxuzjRPMg3paNDc1G z1CgauHg8rR6PHYs/t5bknTYQEPjaq6tG8UV7OZhmdOHG8HySUG1IlQBHg778b0rydI5 Muj9kF1eIzDUbvsElhsFZRHMfAzO7mOYOqurpZAC5kHk60gblIo6jc+EAJ+p++JRxz8f AMcg== X-Gm-Message-State: ABy/qLbjBRcN7LwUqDTeEfzEimlGrPc85lYid6gYcbaOO0cvwNM7Whfd MQrV8S8/4iOeod0LcFnbcpOqpA== X-Google-Smtp-Source: APBJJlHdaYP6KQEeXomKRN9uoCu1+yo8uHO71sdRJ/mNUCNoupGWQiJZQ4tH2nJN9kqa4WSAGURoBQ== X-Received: by 2002:a05:6512:2346:b0:4fb:7be5:8f4e with SMTP id p6-20020a056512234600b004fb7be58f4emr3008339lfu.6.1689070168929; Tue, 11 Jul 2023 03:09:28 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id 15-20020ac2482f000000b004fb88fffd19sm256372lft.146.2023.07.11.03.09.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 03:09:28 -0700 (PDT) Message-ID: <1090089b-2fa9-9781-51a8-38957e261bfd@linaro.org> Date: Tue, 11 Jul 2023 13:09:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] drm/client: Send hotplug event after registering a client Content-Language: en-GB To: Thomas Zimmermann , javierm@redhat.com, noralf@tronnes.org Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, Mikko Perttunen , Thierry Reding , amd-gfx@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, Russell King , Tomi Valkeinen , Kyungmin Park , Paul Schyska , Torsten Krah , linux-arm-msm@vger.kernel.org, Abhinav Kumar , Maxime Ripard , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, freedreno@lists.freedesktop.org, "Pan, Xinhui" , Seung-Woo Kim , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski , Alex Deucher , Moritz Duge , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20230710091029.27503-1-tzimmermann@suse.de> <325dad0e-38ff-9f60-efc9-0fd711d63267@linaro.org> <117aea3d-c316-509d-7be7-ade155b4ae85@suse.de> From: Dmitry Baryshkov In-Reply-To: <117aea3d-c316-509d-7be7-ade155b4ae85@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 11/07/2023 09:07, Thomas Zimmermann wrote: > Hi > > Am 10.07.23 um 23:11 schrieb Dmitry Baryshkov: > [...] >>> --- >>>   drivers/gpu/drm/armada/armada_fbdev.c     |  4 ---- >>>   drivers/gpu/drm/drm_client.c              | 21 +++++++++++++++++++++ >>>   drivers/gpu/drm/drm_fbdev_dma.c           |  4 ---- >>>   drivers/gpu/drm/drm_fbdev_generic.c       |  4 ---- >>>   drivers/gpu/drm/exynos/exynos_drm_fbdev.c |  4 ---- >>>   drivers/gpu/drm/gma500/fbdev.c            |  4 ---- >>>   drivers/gpu/drm/msm/msm_fbdev.c           |  4 ---- >> >> Reviewed-by: Dmitry Baryshkov # msm > > Thanks. > >> >>>   drivers/gpu/drm/omapdrm/omap_fbdev.c      |  4 ---- >>>   drivers/gpu/drm/radeon/radeon_fbdev.c     |  4 ---- >>>   drivers/gpu/drm/tegra/fbdev.c             |  4 ---- >>>   10 files changed, 21 insertions(+), 36 deletions(-) >> >> BTW: As you have been clearing this area. I see that significant >> amount of DRM drivers use exactly the same code for >> msm_fbdev_client_funcs and for the significant part of >> foo_fbdev_setup(). Do you have any plans for moving that into a >> library / generic code? If not, I can take a look at crafting the patch. >> > > You're not the first to ask. :) I've so far not attempted to address > this duplication. I've been bitten by premature helperization before, so > I wanted to wait a bit longer. A lot of the fbdev and client code is > changing quite a bit. After things stabilized, I want to to try to do > some more code sharing. Ack, thank you for sharing this. -- With best wishes Dmitry