From: Sui Jingfeng <15330273260@189.cn>
To: Thomas Zimmermann <tzimmermann@suse.de>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
javierm@redhat.com, airlied@gmail.com, daniel@ffwll.ch
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [1/7] drm/tegra: Include <linux/of.h>
Date: Mon, 3 Apr 2023 21:46:01 +0800 [thread overview]
Message-ID: <1205553a-381a-bab0-4265-eca0bfcd8b9d@189.cn> (raw)
In-Reply-To: <ffb0005d-d871-1317-8b16-d6fe3771a35e@suse.de>
Hi,
On 2023/4/3 18:42, Thomas Zimmermann wrote:
>
>
> Am 30.03.23 um 14:51 schrieb Sui Jingfeng:
>>
>> Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn
>> <mailto:suijingfeng@loongson.cn>>
>
> Thanks a lot.
>
I send my mail with Thunderbird mail client, don't know this does this
look like this.
Sorry about that. It should be:
Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn>
Please correct it manually, others patches also look good to me.
Yet, it beyond my ability to review, I still digging your patch and
learning from it. :)
>>
>>
>> On 2023/3/30 16:36, Thomas Zimmermann wrote:
>>> Include <linux/of.h> to get the contained declarations. No functional
>>> changes.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> drivers/gpu/drm/tegra/output.c | 2 ++
>>> drivers/gpu/drm/tegra/rgb.c | 1 +
>>> 2 files changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/tegra/output.c
>>> b/drivers/gpu/drm/tegra/output.c
>>> index a8925dcd7edd..d31c87f48da0 100644
>>> --- a/drivers/gpu/drm/tegra/output.c
>>> +++ b/drivers/gpu/drm/tegra/output.c
>>> @@ -4,6 +4,8 @@
>>> * Copyright (C) 2012 NVIDIA CORPORATION. All rights reserved.
>>> */
>>> +#include <linux/of.h>
>>> +
>>> #include <drm/drm_atomic_helper.h>
>>> #include <drm/drm_of.h>
>>> #include <drm/drm_panel.h>
>>> diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c
>>> index ff8fce36d2aa..3f060282cd8d 100644
>>> --- a/drivers/gpu/drm/tegra/rgb.c
>>> +++ b/drivers/gpu/drm/tegra/rgb.c
>>> @@ -5,6 +5,7 @@
>>> */
>>> #include <linux/clk.h>
>>> +#include <linux/of.h>
>>> #include <drm/drm_atomic_helper.h>
>>> #include <drm/drm_bridge_connector.h>
>
next prev parent reply other threads:[~2023-04-03 13:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 8:36 [PATCH 0/7] drm/tegra: Convert fbdev to DRM client Thomas Zimmermann
2023-03-30 8:36 ` [PATCH 1/7] drm/tegra: Include <linux/of.h> Thomas Zimmermann
2023-03-30 12:51 ` [1/7] " Sui Jingfeng
2023-04-03 10:42 ` Thomas Zimmermann
2023-04-03 13:46 ` Sui Jingfeng [this message]
2023-03-30 8:36 ` [PATCH 2/7] drm/tegra: Include <linux/i2c.h> Thomas Zimmermann
2023-03-30 12:52 ` [2/7] " Sui Jingfeng
2023-03-30 8:36 ` [PATCH 3/7] drm/tegra: Removed fb from struct tegra_fbdev Thomas Zimmermann
2023-03-30 8:36 ` [PATCH 4/7] drm/tegra: Remove " Thomas Zimmermann
2023-03-30 8:36 ` [PATCH 5/7] drm/tegra: Hide fbdev support behind config option Thomas Zimmermann
2023-03-30 8:36 ` [PATCH 6/7] drm/tegra: Initialize fbdev DRM client Thomas Zimmermann
2023-03-30 8:36 ` [PATCH 7/7] drm/tegra: Implement fbdev emulation as in-kernel client Thomas Zimmermann
2023-04-05 14:55 ` [PATCH 0/7] drm/tegra: Convert fbdev to DRM client Thierry Reding
2023-04-05 15:06 ` Thomas Zimmermann
2023-04-05 15:04 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205553a-381a-bab0-4265-eca0bfcd8b9d@189.cn \
--to=15330273260@189.cn \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox