From: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
To: Thierry Reding
<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v4 2/2] ARM: tegra: paz00: enable backlight
Date: Sat, 17 Nov 2012 15:23:40 +0100 [thread overview]
Message-ID: <123016999.bBqXnoyJOV@ax5200p> (raw)
In-Reply-To: <20121117073534.GD26391-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
On Saturday 17 November 2012 08:35:34 Thierry Reding wrote:
> On Sat, Nov 17, 2012 at 12:20:32AM +0100, Marc Dietrich wrote:
> [...]
>
> > + step1 {
> > + type = "gpio";
> > + gpio = <&gpio 4 0>; /* gpio PA4, en_vdd_pnl */
> > + value = <1>;
> > + };
> > + step2 {
> > + type = "gpio";
> > + gpio = <&gpio 176 0>; /* gpio PW0, bl_vdd */
> > + value = <1>;
> > + };
>
> These look like regulators, so maybe they should be abstracted as such?
Honstly, I never understood why we need to redefine a gpio as a regulator.
IMHO, gpios don't regulate, they switch 0/1. But yes, these gpios just go to
some FET which switches on some supply voltage.
Marc
next prev parent reply other threads:[~2012-11-17 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 23:20 [PATCH v4 1/2] ARM: tegra: paz00: Add host1x support Marc Dietrich
[not found] ` <138e6f406aef20f6257a8f90af45865bd9c88092.1353107865.git.marvin24-Mmb7MZpHnFY@public.gmane.org>
2012-11-16 23:20 ` [PATCH v4 2/2] ARM: tegra: paz00: enable backlight Marc Dietrich
[not found] ` <4de446eaf895ffa01d397cf70cec02620e16f690.1353107865.git.marvin24-Mmb7MZpHnFY@public.gmane.org>
2012-11-17 7:35 ` Thierry Reding
[not found] ` <20121117073534.GD26391-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-17 14:23 ` Marc Dietrich [this message]
2012-11-17 15:04 ` Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=123016999.bBqXnoyJOV@ax5200p \
--to=marvin24-mmb7mzphnfy@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox