From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5144417B427 for ; Fri, 20 Sep 2024 14:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726844049; cv=none; b=aOhOsqKe61weDat5QnZP7k8gTmiL/+P0a0JMVkHd3YjUFtLVMw+xIu4MVXpgzZ7fdQMUkquNxjADPD9O+3NTidB+JvylEPwYKd2JNXH2Si90Fg1TpJI0rKsoO9XJMe6qq3XQ4110+RaHxLzxqGMLIDPbpBv/9Adz0kOFM3AjkkA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726844049; c=relaxed/simple; bh=S4P7L6S4YVxHG7FlOc9S8smNJC+oJB3xqP6RGBINWaE=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=RxhYlcNOPRq3VAflHKKGIEB9VLrxyW4jy+qgjT1pyQ+X8qROz9CBOvfcBJJrt+3uQ6mnphe6pExPNwisenxdq/WB5GmwE9OE4RdUTCkSwgVxPrXalSxUgzMISFRGzE7DUdDon6Q054Ip6OpJWmVJWtTosk1GRflKEHp/jd+OKhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1srf0f-0002Ol-7i; Fri, 20 Sep 2024 16:53:25 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1srf0Z-000H55-Qp; Fri, 20 Sep 2024 16:53:19 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1srf0Z-000BDt-2K; Fri, 20 Sep 2024 16:53:19 +0200 Message-ID: <13010c194e4674f6bdef84bcf748030a1d46b814.camel@pengutronix.de> Subject: Re: [PATCH v2 3/5] drm/imx/ipuv3: Use IRQF_NO_AUTOEN flag in request_irq() From: Philipp Zabel To: Jinjie Ruan , laurentiu.palcu@oss.nxp.com, l.stach@pengutronix.de, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robdclark@gmail.com, sean@poorly.run, konradybcio@kernel.org, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, marijn.suijten@somainline.org, thierry.reding@gmail.com, mperttunen@nvidia.com, jonathanh@nvidia.com, agx@sigxcpu.org, gregkh@linuxfoundation.org, jordan@cosmicpenguin.net, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org Date: Fri, 20 Sep 2024 16:53:19 +0200 In-Reply-To: <20240912083020.3720233-4-ruanjinjie@huawei.com> References: <20240912083020.3720233-1-ruanjinjie@huawei.com> <20240912083020.3720233-4-ruanjinjie@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-tegra@vger.kernel.org On Do, 2024-09-12 at 16:30 +0800, Jinjie Ruan wrote: > disable_irq() after request_irq() still has a time gap in which > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will > disable IRQ auto-enable when request IRQ. >=20 > Fixes: 47b1be5c0f4e ("staging: imx/drm: request irq only after adding the= crtc") > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Jinjie Ruan Reviewed-by: Philipp Zabel regards Philipp