From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH v2] ARM: Tegra: select MACH_HAS_SND_SOC_TEGRA_WM8903 Date: Wed, 20 Apr 2011 12:12:19 +0100 Message-ID: <1303297939.3436.3.camel@odin> References: <1303229881-9054-1-git-send-email-swarren@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1303229881-9054-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org, konkers-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Tue, 2011-04-19 at 10:18 -0600, Stephen Warren wrote: > CONFIG_SND_SOC_TEGRA_WM8903 is useful for many Tegra boards. To avoid the > ASoC tegra/Kconfig enumerating them all, instead have the Tegra machine > Kconfig select MACH_HAS_SND_SOC_TEGRA_WM8903 where appropriate, and have > SND_SOC_TEGRA_WM8903 depend on this. > > Signed-off-by: Stephen Warren > --- > Mark, this will need to be applied to your tegra branch so it can get > merged into both trees. Thanks. > > v2: s/HAS/WANT/ in Kconfig variable name. > I figured a machine "HAVING" a Kconfig variable didn't make much sense. > I also wondered about ALLOW/ENABLE. > Still, being consistent with existing variable naming is more important > that the finer details of English:-) > Acked-by: Liam Girdwood