From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Stephen Warren <swarren@nvidia.com>
Cc: linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com, mike@compulab.co.il
Subject: Re: [Patch v2 1/6] ASoC: Tegra: wm8903 probe: Don't call machine_is_*()
Date: Wed, 20 Apr 2011 12:35:03 +0100 [thread overview]
Message-ID: <1303299303.3436.4.camel@odin> (raw)
In-Reply-To: <1303248312-22664-1-git-send-email-swarren@nvidia.com>
On Tue, 2011-04-19 at 15:25 -0600, Stephen Warren wrote:
> This machine driver is a platform driver, and hence will only be
> instantiated on the correct machines. Hence, there is no need to
> check the current machine during probe.
>
> (Applying Mark's TrimSlice review comments to the existing driver)
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> sound/soc/tegra/tegra_wm8903.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/sound/soc/tegra/tegra_wm8903.c b/sound/soc/tegra/tegra_wm8903.c
> index 37f6010..1eb0632 100644
> --- a/sound/soc/tegra/tegra_wm8903.c
> +++ b/sound/soc/tegra/tegra_wm8903.c
> @@ -391,13 +391,6 @@ static __devinit int tegra_wm8903_driver_probe(struct platform_device *pdev)
> struct tegra_wm8903_platform_data *pdata;
> int ret;
>
> - if (!machine_is_harmony() && !machine_is_ventana() &&
> - !machine_is_seaboard() && !machine_is_kaen() &&
> - !machine_is_aebl()) {
> - dev_err(&pdev->dev, "Not running on a supported board!\n");
> - return -ENODEV;
> - }
> -
> pdata = pdev->dev.platform_data;
> if (!pdata) {
> dev_err(&pdev->dev, "No platform data supplied\n");
All
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-04-20 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 21:25 [Patch v2 1/6] ASoC: Tegra: wm8903 probe: Don't call machine_is_*() Stephen Warren
[not found] ` <1303248312-22664-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-04-19 21:25 ` [Patch v2 2/6] ASoC: Tegra: wm8903: Remove redundant drvdata clears Stephen Warren
2011-04-19 21:25 ` [Patch v2 3/6] ASoC: Tegra: Don't return mclk_changed from utils_set_rate Stephen Warren
2011-04-19 21:25 ` [Patch v2 4/6] ASoC: Tegra: Retrieve card from DAPM context not codec Stephen Warren
2011-04-19 21:25 ` [Patch v2 5/6] ASoC: snd_soc_dapm_get_pin_status: Match other contexts too Stephen Warren
2011-04-19 21:25 ` [Patch v2 6/6] ASoC: Tegra: wm8903: s/code/data/ for control/widget/maps Stephen Warren
2011-04-20 11:35 ` Liam Girdwood [this message]
2011-04-20 12:59 ` [Patch v2 1/6] ASoC: Tegra: wm8903 probe: Don't call machine_is_*() Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303299303.3436.4.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-tegra@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox