From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: [PATCH V3 2/2] regmap: add regmap_bulk_write() for register write Date: Fri, 10 Feb 2012 21:30:28 +0530 Message-ID: <1328889628-13151-2-git-send-email-ldewangan@nvidia.com> References: <1328889628-13151-1-git-send-email-ldewangan@nvidia.com> Return-path: In-Reply-To: <1328889628-13151-1-git-send-email-ldewangan@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org To: broonie@opensource.wolfsonmicro.com, gregkh@linuxfoundation.org, lars@metafoo.de, linux-kernel@vger.kernel.org Cc: linux-tegra@vger.kernel.org, ldewangan@nvidia.com List-Id: linux-tegra@vger.kernel.org The bulk_write() supports the data transfer to multi register which takes the data into cpu_endianness format and does formatting of data to device format before sending to device. The transfer can be completed in single transfer or multiple transfer based on data formatting. Signed-off-by: Laxman Dewangan --- Changes from V1: - Change commit message. - Byte swapping in input data packet. Changes from V2: - Remove formatting if val_byte is 1. - Allocating proper size of memory for val_byte != 1 drivers/base/regmap/regmap.c | 61 ++++++++++++++++++++++++++++++++++++++++++ include/linux/regmap.h | 2 + 2 files changed, 63 insertions(+), 0 deletions(-) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index ba92217..a1656a7 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -482,6 +482,67 @@ int regmap_raw_write(struct regmap *map, unsigned int reg, } EXPORT_SYMBOL_GPL(regmap_raw_write); +/* + * regmap_bulk_write(): Write multiple registers to the device + * + * @map: Register map to write to + * @reg: First register to be write from + * @val: Block of data to be written, in native register size for device + * @val_count: Number of registers to write + * + * This function is intended to be used for writing a large block of + * data to be device either in single transfer or multiple transfer. + * + * A value of zero will be returned on success, a negative errno will + * be returned in error cases. + */ +int regmap_bulk_write(struct regmap *map, unsigned int reg, const void *val, + size_t val_count) +{ + int ret = 0, i; + unsigned int ival; + size_t val_bytes = map->format.val_bytes; + + mutex_lock(&map->lock); + + if (map->format.parse_val) { + void *wval; + /* No formatting is require if val_byte is 1 */ + if (val_bytes == 1) + wval = (void *)val; + else { + wval = kmemdup(val, val_count * val_bytes, GFP_KERNEL); + if (!wval) { + mutex_unlock(&map->lock); + dev_err(map->dev, + "Error in memory allocation\n"); + return -ENOMEM; + } + for (i = 0; i < val_count * val_bytes; i += val_bytes) + map->format.parse_val(wval + i); + } + ret = _regmap_raw_write(map, reg, wval, val_bytes * val_count); + + if (val_bytes != 1) + kfree(wval); + } else { + for (i = 0; i < val_count; i++) { + memcpy(&ival, val + (i * val_bytes), val_bytes); + ret = _regmap_write(map, reg + i, ival); + if (ret) { + dev_err(map->dev, + "Error in register %u write, ret %d\n", + reg + i, ret); + break; + } + } + } + + mutex_unlock(&map->lock); + return ret; +} +EXPORT_SYMBOL_GPL(regmap_bulk_write); + static int _regmap_raw_read(struct regmap *map, unsigned int reg, void *val, unsigned int val_len) { diff --git a/include/linux/regmap.h b/include/linux/regmap.h index a6ed6e6..0925e24 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -135,6 +135,8 @@ int regmap_reinit_cache(struct regmap *map, int regmap_write(struct regmap *map, unsigned int reg, unsigned int val); int regmap_raw_write(struct regmap *map, unsigned int reg, const void *val, size_t val_len); +int regmap_bulk_write(struct regmap *map, unsigned int reg, const void *val, + size_t val_count); int regmap_read(struct regmap *map, unsigned int reg, unsigned int *val); int regmap_raw_read(struct regmap *map, unsigned int reg, void *val, size_t val_len); -- 1.7.1.1