Linux Tegra architecture development
 help / color / mirror / Atom feed
From: Mikko Perttunen <mperttunen@nvidia.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Dmitry Osipenko <digetx@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: tegra: Don't mark devices with pins as IRQ safe
Date: Fri, 06 Feb 2026 12:38:08 +0900	[thread overview]
Message-ID: <13293829.O9o76ZdvQC@senjougahara> (raw)
In-Reply-To: <aYRzq2n1VU-fTXaO@zenone.zhora.eu>

On Thursday, February 5, 2026 7:47 PM Andi Shyti wrote:
> Hi Mikko,
> 
> On Mon, Feb 02, 2026 at 01:42:34PM +0900, Mikko Perttunen wrote:
> > I2C devices with associated pinctrl states (DPAUX I2C controllers)
> > will change pinctrl state during runtime PM. This requires taking
> > a mutex, so these devices cannot be marked as IRQ safe.
> > 
> > Discovered through lockdep.
> 
> I removed this sentence...

Sorry about that.

> 
> > Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> 
> ... and merged the patch in i2c/i2c-host-2.
> 
> Thanks,
> Andi
> 

Thank you!

Looks like there's a COMPILE_TEST failure so we'll need to do something like ..

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index e11d50750e63..09152088b79f 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -1211,7 +1211,7 @@ config I2C_SYNQUACER
 
 config I2C_TEGRA
 	tristate "NVIDIA Tegra internal I2C controller"
-	depends on ARCH_TEGRA || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
+	depends on ARCH_TEGRA || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC) && PINCTRL)
 	# COMPILE_TEST needs architectures with readsX()/writesX() primitives
 	help
 	  If you say yes to this option, support will be included for the
-- 
2.52.0

Please let me know how you'd like to go about it.

Mikko



  reply	other threads:[~2026-02-06  3:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02  4:42 [PATCH] i2c: tegra: Don't mark devices with pins as IRQ safe Mikko Perttunen
2026-02-02  5:08 ` Mikko Perttunen
2026-02-05 10:47 ` Andi Shyti
2026-02-06  3:38   ` Mikko Perttunen [this message]
2026-02-07  0:25 ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13293829.O9o76ZdvQC@senjougahara \
    --to=mperttunen@nvidia.com \
    --cc=andi.shyti@kernel.org \
    --cc=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox