From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Ni Subject: Re: How to use the generic thermal sysfs. Date: Wed, 1 Aug 2012 19:29:51 +0800 Message-ID: <1343820591.2295.79.camel@tegra-chromium-2> References: <1342088573.27605.101.camel@tegra-chromium-2> <4D68720C2E767A4AA6A8796D42C8EB5915287C@BGSMSX101.gar.corp.intel.com> <1342144273.1682.237.camel@rui.sh.intel.com> <1342164616.27605.129.camel@tegra-chromium-2> <1342165278.1682.259.camel@rui.sh.intel.com> <1343295094.4042.24.camel@tegra-chromium-2> <1343352098.1682.447.camel@rui.sh.intel.com> <1343357901.4042.70.camel@tegra-chromium-2> <20120727093037.094335eb@endymion.delvare> <1343374793.1682.475.camel@rui.sh.intel.com> <1343386122.4042.88.camel@tegra-chromium-2> <1343782972.1682.489.camel@rui.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1343782972.1682.489.camel@rui.sh.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Zhang Rui Cc: Jean Delvare , "R, Durgadoss" , "Brown, Len" , "akpm@linux-foundation.org" , "joe@perches.com" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , Alex Courbot List-Id: linux-tegra@vger.kernel.org On Wed, 2012-08-01 at 09:02 +0800, Zhang Rui wrote: > On =E4=BA=94, 2012-07-27 at 18:48 +0800, Wei Ni wrote: > > On Fri, 2012-07-27 at 15:39 +0800, Zhang Rui wrote: > > > On =E4=BA=94, 2012-07-27 at 09:30 +0200, Jean Delvare wrote: > > > > On Fri, 27 Jul 2012 10:58:21 +0800, Wei Ni wrote: > > > > > On Fri, 2012-07-27 at 09:21 +0800, Zhang Rui wrote: > > > > > > is it possible to program the sensor at this time, in your = own thermal > > > > > > driver? > > > > >=20 > > > > > Since we are using the generic thermal driver lm90.c, I'm not= sure if we > > > > > could program these limits in the generic driver, I think it'= s better to > > > > > have a generic interface to set the limits, so I wish to add = a > > > > > callback .set_limits() in the generic thermal framework. > > > >=20 > > > > I can confirm that hwmon drivers do not set limits, it is up to > > > > user-space to do it if they want. So if there is a need to do s= o in the > > > > kernel itself, a proper interface at the generic thermal framew= ork > > > > level seems appropriate. > > > >=20 > > > oh, setting limits from userspace? > > > I think you can program the senor when writing the trip point? > > > with this patch, > > > http://marc.info/?l=3Dlinux-acpi&m=3D134318814620429&w=3D2 > >=20 > > Do you mean it can use .set_trip_temp() to set limits when writing = the > > trip point? But I think this callback is used to change the trip_te= mp, > > it could not used to set the limits, in here the limit value is use= d to > > trigger the interrupt. > >=20 > yes, you are right. .set_trip_temp does not work. >=20 > usually, this is needed to re-program the sensor when the temperature > hits a trip point , right? Yes, we need to re-program the sensor to set the limit value. >=20 > can we make use of the thermal_zone_device_ops.notify()? > say we invoke .notify() in thermal_zone_device_update for each trip > point. oh, it's a good idea, we can re-program the sensor in the .notify(), is it right? I will try it later, thanks for your suggestions. >=20 > thanks, > rui