From: Laxman Dewangan <ldewangan@nvidia.com>
To: akpm@linux-foundation.org, a.zummo@towertech.it
Cc: swarren@wwwdotorg.org, rtc-linux@googlegroups.com,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
thierry.reding@avionic-design.de,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: [PATCH V2 1/5] rtc: tegra: protect suspend/resume callbacks with CONFIG_PM_SLEEP
Date: Mon, 11 Mar 2013 14:14:24 +0530 [thread overview]
Message-ID: <1362991468-30226-2-git-send-email-ldewangan@nvidia.com> (raw)
In-Reply-To: <1362991468-30226-1-git-send-email-ldewangan@nvidia.com>
The CONFIG_PM doesn't actually enable any of the PM callbacks, it
only allows to enable CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
This means if CONFIG_PM is used to protect system sleep callbacks
then it may end up unreferenced if only runtime PM is enabled.
Hence protecting sleep callbacks with CONFIG_PM_SLEEP.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
---
Changes from V1:
- Add Thierry's reviewed by.
- No Change in code.
drivers/rtc/rtc-tegra.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c
index 0020bab..d64cde6 100644
--- a/drivers/rtc/rtc-tegra.c
+++ b/drivers/rtc/rtc-tegra.c
@@ -390,7 +390,7 @@ static int __exit tegra_rtc_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
static int tegra_rtc_suspend(struct platform_device *pdev, pm_message_t state)
{
struct device *dev = &pdev->dev;
@@ -446,7 +446,7 @@ static struct platform_driver tegra_rtc_driver = {
.owner = THIS_MODULE,
.of_match_table = tegra_rtc_dt_match,
},
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
.suspend = tegra_rtc_suspend,
.resume = tegra_rtc_resume,
#endif
--
1.7.1.1
next prev parent reply other threads:[~2013-03-11 8:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 8:44 [PATCH V2 0/5] rtc: tegra: cleanups to remove warning/code lines Laxman Dewangan
2013-03-11 8:44 ` Laxman Dewangan [this message]
2013-03-11 8:44 ` [PATCH V2 2/5] rtc: tegra: Use struct dev_pm_ops for power management Laxman Dewangan
[not found] ` <1362991468-30226-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-11 8:51 ` Thierry Reding
[not found] ` <20130311085132.GA7900-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2013-03-11 8:56 ` Laxman Dewangan
[not found] ` <513D9C48.8090505-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-11 17:18 ` Stephen Warren
[not found] ` <513E11EE.1020405-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-11 17:51 ` Laxman Dewangan
2013-03-11 8:44 ` [PATCH V2 3/5] rtc: tegra: use module_platform_driver_probe for module init/exit Laxman Dewangan
2013-03-11 8:44 ` [PATCH V2 4/5] rtc: tegra: set irq name as device name Laxman Dewangan
2013-03-11 8:44 ` [PATCH V2 5/5] rtc: tegra: use managed rtc_device_register Laxman Dewangan
[not found] ` <1362991468-30226-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-11 17:19 ` [PATCH V2 0/5] rtc: tegra: cleanups to remove warning/code lines Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362991468-30226-2-git-send-email-ldewangan@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox