* [PATCH 1/1] ARM: dt: tegra114: add PWM nodes
@ 2013-03-11 22:30 Andrew Chew
[not found] ` <1363041036-26358-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Chew @ 2013-03-11 22:30 UTC (permalink / raw)
To: hdoyu-DDmLM1+adcrQT0dZR+AlfA, swarren-3lzwWm7+Weoh9ZMKESR00Q
Cc: achew-DDmLM1+adcrQT0dZR+AlfA, linux-tegra-u79uwXL29TY76Z2rM5mHXA
This patch adds device tree nodes for the four PWM controllers present
on tegra114.
Signed-off-by: Andrew Chew <achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
arch/arm/boot/dts/tegra114.dtsi | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
index 1dfaf28..68fc0e1 100644
--- a/arch/arm/boot/dts/tegra114.dtsi
+++ b/arch/arm/boot/dts/tegra114.dtsi
@@ -150,4 +150,36 @@
<1 11 0xf08>,
<1 10 0xf08>;
};
+
+ pwm0: pwm@7000a000 {
+ compatible = "nvidia,tegra20-pwm";
+ reg = <0x7000a000 0x4>;
+ #pwm-cells = <2>;
+ clocks = <&tegra_car 17>;
+ status = "disabled";
+ };
+
+ pwm1: pwm@7000a010 {
+ compatible = "nvidia,tegra20-pwm";
+ reg = <0x7000a010 0x4>;
+ #pwm-cells = <2>;
+ clocks = <&tegra_car 17>;
+ status = "disabled";
+ };
+
+ pwm2: pwm@7000a020 {
+ compatible = "nvidia,tegra20-pwm";
+ reg = <0x7000a020 0x4>;
+ #pwm-cells = <2>;
+ clocks = <&tegra_car 17>;
+ status = "disabled";
+ };
+
+ pwm3: pwm@7000a030 {
+ compatible = "nvidia,tegra20-pwm";
+ reg = <0x7000a030 0x4>;
+ #pwm-cells = <2>;
+ clocks = <&tegra_car 17>;
+ status = "disabled";
+ };
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] ARM: dt: tegra114: add PWM nodes
[not found] ` <1363041036-26358-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
@ 2013-03-11 23:30 ` Stephen Warren
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Warren @ 2013-03-11 23:30 UTC (permalink / raw)
To: Andrew Chew
Cc: hdoyu-DDmLM1+adcrQT0dZR+AlfA, linux-tegra-u79uwXL29TY76Z2rM5mHXA
On 03/11/2013 04:30 PM, Andrew Chew wrote:
> This patch adds device tree nodes for the four PWM controllers present
> on tegra114.
Nit: Capitalize Tegra.
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> @@ -150,4 +150,36 @@
> <1 11 0xf08>,
> <1 10 0xf08>;
> };
DT nodes should be sorted in order by reg address, so I think this is in
the wrong place.
> + pwm0: pwm@7000a000 {
> + compatible = "nvidia,tegra20-pwm";
If the HW is 100% backwards-compatible, that should be:
compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
if not:
compatible = "nvidia,tegra114-pwm";
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-11 23:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-11 22:30 [PATCH 1/1] ARM: dt: tegra114: add PWM nodes Andrew Chew
[not found] ` <1363041036-26358-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-11 23:30 ` Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox