[PATCH 1/1] ARM: dt: tegra114: add PWM nodes

[PATCH 1/1] ARM: dt: tegra114: add PWM nodes

[Andrew Chew]

This patch adds device tree nodes for the four PWM controllers present
on tegra114.

Signed-off-by: Andrew Chew <achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 arch/arm/boot/dts/tegra114.dtsi |   32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
index 1dfaf28..68fc0e1 100644
--- a/arch/arm/boot/dts/tegra114.dtsi
+++ b/arch/arm/boot/dts/tegra114.dtsi
@@ -150,4 +150,36 @@
 			     <1 11 0xf08>,
 			     <1 10 0xf08>;
 	};
+
+	pwm0: pwm@7000a000 {
+		compatible = "nvidia,tegra20-pwm";
+		reg = <0x7000a000 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
+
+	pwm1: pwm@7000a010 {
+		compatible = "nvidia,tegra20-pwm";
+		reg = <0x7000a010 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
+
+	pwm2: pwm@7000a020 {
+		compatible = "nvidia,tegra20-pwm";
+		reg = <0x7000a020 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
+
+	pwm3: pwm@7000a030 {
+		compatible = "nvidia,tegra20-pwm";
+		reg = <0x7000a030 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
 };
-- 
1.7.9.5

Re: [PATCH 1/1] ARM: dt: tegra114: add PWM nodes

[Stephen Warren]

On 03/11/2013 04:30 PM, Andrew Chew wrote:
> This patch adds device tree nodes for the four PWM controllers present
> on tegra114.

Nit: Capitalize Tegra.

> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi

> @@ -150,4 +150,36 @@
>  			     <1 11 0xf08>,
>  			     <1 10 0xf08>;
>  	};

DT nodes should be sorted in order by reg address, so I think this is in
the wrong place.

> +	pwm0: pwm@7000a000 {
> +		compatible = "nvidia,tegra20-pwm";

If the HW is 100% backwards-compatible, that should be:

compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";

if not:

compatible = "nvidia,tegra114-pwm";