From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Linux USB Mailing List
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
Greg KH
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Subject: [PATCH 4/9] usb: musb: omap2430: fix PHY error handling
Date: Fri, 15 Mar 2013 11:12:05 +0200 [thread overview]
Message-ID: <1363338730-14581-5-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1363338730-14581-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
PHY layer no longer returns NULL. It will
return -ENXIO when PHY layer isn't enabled
and we can use that to bail out instead of
request a probe deferral.
Signed-off-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
---
drivers/usb/musb/omap2430.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index ec460ea..798e029 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -353,7 +353,12 @@ static int omap2430_musb_init(struct musb *musb)
else
musb->xceiv = devm_usb_get_phy_dev(dev, 0);
- if (IS_ERR_OR_NULL(musb->xceiv)) {
+ if (IS_ERR(musb->xceiv)) {
+ status = PTR_ERR(musb->xceiv);
+
+ if (status == -ENXIO)
+ return status;
+
pr_err("HS USB OTG: no transceiver configured\n");
return -EPROBE_DEFER;
}
--
1.8.2
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-03-15 9:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 9:12 [PATCH 0/9] usb: fix PHY error handling Felipe Balbi
[not found] ` <1363338730-14581-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2013-03-15 9:12 ` [PATCH 1/9] usb: dwc3: " Felipe Balbi
2013-03-15 9:12 ` [PATCH 2/9] usb: gadget: mv_udc_core: " Felipe Balbi
2013-03-15 9:12 ` [PATCH 3/9] usb: gadget: s3c-hsotg: " Felipe Balbi
2013-03-15 9:12 ` Felipe Balbi [this message]
2013-03-15 9:12 ` [PATCH 5/9] usb: host: ehci-msm: " Felipe Balbi
2013-03-15 9:12 ` [PATCH 6/9] usb: host: ehci-mv: " Felipe Balbi
2013-03-15 9:12 ` [PATCH 7/9] usb: host: ehci-s5p: " Felipe Balbi
2013-03-15 9:12 ` [PATCH 8/9] usb: host: ehci-tegra: " Felipe Balbi
[not found] ` <1363338730-14581-9-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2013-03-15 21:12 ` Stephen Warren
[not found] ` <51438EA8.1060301-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-18 8:02 ` Felipe Balbi
[not found] ` <20130318080245.GI17135-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-03-18 15:25 ` Stephen Warren
[not found] ` <514731EE.9010709-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-19 8:24 ` Felipe Balbi
2013-03-18 16:08 ` Greg KH
2013-03-15 9:12 ` [PATCH 9/9] usb: host: ohci-exynos: " Felipe Balbi
2013-03-15 15:01 ` [PATCH 0/9] usb: " Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363338730-14581-5-git-send-email-balbi@ti.com \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).