From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: [PATCH 09/12] tegra20-apb-dma: remove useless use of lock Date: Mon, 27 May 2013 15:14:39 +0300 Message-ID: <1369656882-25241-10-git-send-email-andriy.shevchenko@linux.intel.com> References: <1369656882-25241-1-git-send-email-andriy.shevchenko@linux.intel.com> Return-path: In-Reply-To: <1369656882-25241-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org, Vinod Koul , Dan Williams Cc: Andy Shevchenko , Stephen Warren , linux-tegra@vger.kernel.org List-Id: linux-tegra@vger.kernel.org Accordingly to dma_cookie_status() description locking is not required. Signed-off-by: Andy Shevchenko Cc: Stephen Warren Cc: linux-tegra@vger.kernel.org --- drivers/dma/tegra20-apb-dma.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index 33f59ec..019ccfa 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/drivers/dma/tegra20-apb-dma.c @@ -767,13 +767,11 @@ static enum dma_status tegra_dma_tx_status(struct dma_chan *dc, unsigned long flags; unsigned int residual; - spin_lock_irqsave(&tdc->lock, flags); - ret = dma_cookie_status(dc, cookie, txstate); - if (ret == DMA_SUCCESS) { - spin_unlock_irqrestore(&tdc->lock, flags); + if (ret == DMA_SUCCESS) return ret; - } + + spin_lock_irqsave(&tdc->lock, flags); /* Check on wait_ack desc status */ list_for_each_entry(dma_desc, &tdc->free_dma_desc, node) { -- 1.8.2.rc0.22.gb3600c3