From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH v2] regulator: core: set full constraints in regulator_init
Date: Wed, 6 Nov 2013 15:19:40 +0800 [thread overview]
Message-ID: <1383722380-5845-1-git-send-email-wni@nvidia.com> (raw)
When use DT to probe device, the probe routine may be erailier than
regulator_init_complete(), so at that time the full_constraints isn't
set yet, then the regulator_get() can't get the dummy regulator if the
regulator is physically present and enabled.
Set the full constraints in regulator_init() can fix this problem.
Discussed this in the link:
https://lkml.org/lkml/2013/10/8/40
Signed-off-by: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
drivers/regulator/core.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 6382f0a..e80dd88 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -3773,6 +3773,15 @@ static int __init regulator_init(void)
regulator_dummy_init();
+ /*
+ * Since DT doesn't provide an idiomatic mechanism for
+ * enabling full constraints and since it's much more natural
+ * with DT to provide them just assume that a DT enabled
+ * system has full constraints.
+ */
+ if (of_have_populated_dt())
+ has_full_constraints = true;
+
return ret;
}
@@ -3786,15 +3795,6 @@ static int __init regulator_init_complete(void)
struct regulation_constraints *c;
int enabled, ret;
- /*
- * Since DT doesn't provide an idiomatic mechanism for
- * enabling full constraints and since it's much more natural
- * with DT to provide them just assume that a DT enabled
- * system has full constraints.
- */
- if (of_have_populated_dt())
- has_full_constraints = true;
-
mutex_lock(®ulator_list_mutex);
/* If we have a full configuration then disable any regulators
--
1.7.9.5
next reply other threads:[~2013-11-06 7:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 7:19 Wei Ni [this message]
[not found] ` <1383722380-5845-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-06 7:23 ` [PATCH v2] regulator: core: set full constraints in regulator_init Wei Ni
2013-11-06 9:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383722380-5845-1-git-send-email-wni@nvidia.com \
--to=wni-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox