Re: [PATCH v2 RESEND 2/2] ASOC: tegra: fix AC97 clock handling

[Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>]

Am Dienstag, den 17.12.2013, 22:39 +0000 schrieb Mark Brown:
> On Tue, Dec 17, 2013 at 03:33:54PM -0700, Stephen Warren wrote:
> > On 12/17/2013 03:28 PM, Mark Brown wrote:
> 
> > > How does doing this in the machine driver help here?  The machine driver
> > > isn't going to be any more coordinated with other machine drivers than
> > > the controller is.
> 
> > There would only be one machine driver loaded at a time. It should
> > provide top-level control over all the audio paths in the Tegra audio
> > subsystem.
> 
> OK, so that's not how everyone else has done these isolated
> controllers...  to be honest I'm not convinced that this is something
> worth worrying about for AC'97 - the clocking is fixed in the spec
> unless you're being fancy and the chances of anyone being fancy are
> minimal these days.  It's probably more likely to make life miserable
> for people trying to get AC'97 working than anything else.
> 
Essentially the only Tegra machine driver using AC97 is providing a
fixed clock. It's just a convention for all Tegra sound drivers to do
the PLL handling in the machine driver, I'd say it just more confusing
to do it another way just for this one corner case.

> But like I say the big thing is a comprehensible changelog.

Ok, I'll resend with a better changelog.

Regards,
Lucas