From: Jisheng Zhang <jszhang@marvell.com>
To: ulf.hansson@linaro.org, swarren@wwwdotorg.org, lee@kernel.org,
eric@anholt.net, michal.simek@xilinx.com,
soren.brinkmann@xilinx.com, ludovic.desroches@atmel.com,
srinivas.kandagatla@gmail.com, maxime.coquelin@st.com,
patrice.chotard@st.com, thierry.reding@gmail.com,
sebastian.hesselbarth@gmail.com
Cc: linux-mmc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
linux-tegra@vger.kernel.org, Jisheng Zhang <jszhang@marvell.com>
Subject: [PATCH 05/11] mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation
Date: Tue, 5 Jan 2016 18:51:33 +0800 [thread overview]
Message-ID: <1451991099-4946-6-git-send-email-jszhang@marvell.com> (raw)
In-Reply-To: <1451991099-4946-1-git-send-email-jszhang@marvell.com>
Commit 0e748234293f ("mmc: sdhci: Add size for caller in init+register")
allows users of sdhci_pltfm to allocate private space in calls to
sdhci_pltfm_init+sdhci_pltfm_register. This patch migrates the
sdhci-of-at91 driver to this allocation.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/mmc/host/sdhci-of-at91.c | 21 ++++++++-------------
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
index 06d0b50..765eb09 100644
--- a/drivers/mmc/host/sdhci-of-at91.c
+++ b/drivers/mmc/host/sdhci-of-at91.c
@@ -68,11 +68,13 @@ static int sdhci_at91_probe(struct platform_device *pdev)
return -EINVAL;
soc_data = match->data;
- priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
- if (!priv) {
- dev_err(&pdev->dev, "unable to allocate private data\n");
- return -ENOMEM;
- }
+ host = sdhci_pltfm_init(pdev, soc_data,
+ sizeof(*priv));
+ if (IS_ERR(host))
+ return PTR_ERR(host);
+
+ pltfm_host = sdhci_priv(host);
+ priv = sdhci_pltfm_priv(pltfm_host);
priv->mainck = devm_clk_get(&pdev->dev, "baseclk");
if (IS_ERR(priv->mainck)) {
@@ -92,10 +94,6 @@ static int sdhci_at91_probe(struct platform_device *pdev)
return PTR_ERR(priv->gck);
}
- host = sdhci_pltfm_init(pdev, soc_data, 0);
- if (IS_ERR(host))
- return PTR_ERR(host);
-
/*
* The mult clock is provided by as a generated clock by the PMC
* controller. In order to set the rate of gck, we have to get the
@@ -135,9 +133,6 @@ static int sdhci_at91_probe(struct platform_device *pdev)
clk_prepare_enable(priv->mainck);
clk_prepare_enable(priv->gck);
- pltfm_host = sdhci_priv(host);
- pltfm_host->priv = priv;
-
ret = mmc_of_parse(host->mmc);
if (ret)
goto clocks_disable_unprepare;
@@ -163,7 +158,7 @@ static int sdhci_at91_remove(struct platform_device *pdev)
{
struct sdhci_host *host = platform_get_drvdata(pdev);
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
- struct sdhci_at91_priv *priv = pltfm_host->priv;
+ struct sdhci_at91_priv *priv = sdhci_pltfm_priv(pltfm_host);
sdhci_pltfm_unregister(pdev);
--
2.6.4
next prev parent reply other threads:[~2016-01-05 10:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 10:51 [PATCH 00/11] mmc: use sdhci_pltfm_init for private allocation and clean up Jisheng Zhang
2016-01-05 10:51 ` [PATCH 01/11] mmc: sdhci-bcm2835: use sdhci_pltfm_init for private allocation Jisheng Zhang
2016-01-05 10:51 ` [PATCH 02/11] mmc: sdhci-esdhc-imx: " Jisheng Zhang
2016-01-05 10:51 ` [PATCH 03/11] mmc: sdhci-msm: " Jisheng Zhang
2016-01-05 12:47 ` kbuild test robot
2016-01-06 2:36 ` Jisheng Zhang
2016-01-05 10:51 ` [PATCH 04/11] mmc: sdhci-of-arasan: " Jisheng Zhang
2016-01-05 10:51 ` Jisheng Zhang [this message]
2016-01-05 10:51 ` [PATCH 06/11] mmc: sdhci-of-esdhc: " Jisheng Zhang
2016-01-05 10:51 ` [PATCH 07/11] mmc: sdhci-pxav3: " Jisheng Zhang
2016-01-05 10:51 ` [PATCH 08/11] mmc: sdhci-st: " Jisheng Zhang
2016-01-05 10:51 ` [PATCH 11/11] mmc: sdhci-pltfm: remove priv variable from sdhci_pltfm_host Jisheng Zhang
[not found] ` <1451991099-4946-1-git-send-email-jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2016-01-05 10:51 ` [PATCH 09/11] mmc: sdhci-tegra: use sdhci_pltfm_init for private allocation Jisheng Zhang
2016-01-05 10:51 ` [PATCH 10/11] mmc: sdhci-pxav2: remove unnecessary assignment of pltfm_host->priv Jisheng Zhang
2016-01-05 11:45 ` [PATCH 00/11] mmc: use sdhci_pltfm_init for private allocation and clean up Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451991099-4946-6-git-send-email-jszhang@marvell.com \
--to=jszhang@marvell.com \
--cc=eric@anholt.net \
--cc=kernel@stlinux.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=maxime.coquelin@st.com \
--cc=michal.simek@xilinx.com \
--cc=patrice.chotard@st.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=soren.brinkmann@xilinx.com \
--cc=srinivas.kandagatla@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).