public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] spi/tegra: fix compilation error in spi-tegra.c
Date: Thu, 13 Oct 2011 11:01:33 +0200	[thread overview]
Message-ID: <1458857.A6MEb356Lm@fb07-iapwap2> (raw)

Add #include <linux/module.h> to spi-tegra.c to fix a compilation error
after the removal of module.h from device.h (in patch: "include: replace 
linux/module.h with "struct module" wherever possible").

Signed-off-by: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Acked-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
---

Hi Grant,

this fixes the error below:

  CC      drivers/spi/spi-tegra.o
drivers/spi/spi-tegra.c:597: error: expected declaration specifiers or '...' before 
string constant
drivers/spi/spi-tegra.c:597: warning: data definition has no type or storage class
drivers/spi/spi-tegra.c:597: warning: type defaults to 'int' in declaration of 
'MODULE_ALIAS'
drivers/spi/spi-tegra.c:597: warning: function declaration isn't a prototype
drivers/spi/spi-tegra.c:604: warning: data definition has no type or storage class
drivers/spi/spi-tegra.c:604: warning: type defaults to 'int' in declaration of 
'MODULE_DEVICE_TABLE'
drivers/spi/spi-tegra.c:604: warning: parameter names (without types) in function 
declaration
drivers/spi/spi-tegra.c:612: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/spi/spi-tegra.c:630: error: expected declaration specifiers or '...' before 
string constant
drivers/spi/spi-tegra.c:630: warning: data definition has no type or storage class
drivers/spi/spi-tegra.c:630: warning: type defaults to 'int' in declaration of 
'MODULE_LICENSE'
drivers/spi/spi-tegra.c:630: warning: function declaration isn't a prototype
make[2]: *** [drivers/spi/spi-tegra.o] Error 1

It is against linux-next (for 3.2). Please apply.

Thanks
			Marc

diff --git a/drivers/spi/spi-tegra.c b/drivers/spi/spi-tegra.c
index a5a6302..e8cd58f 100644
--- a/drivers/spi/spi-tegra.c
+++ b/drivers/spi/spi-tegra.c
@@ -18,6 +18,7 @@
  */
 
 #include <linux/kernel.h>
+#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/err.h>
 #include <linux/platform_device.h>

             reply	other threads:[~2011-10-13  9:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13  9:01 Marc Dietrich [this message]
2011-10-13 19:27 ` [PATCH] spi/tegra: fix compilation error in spi-tegra.c Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458857.A6MEb356Lm@fb07-iapwap2 \
    --to=marvin24-mmb7mzphnfy@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox