Re: [PATCH] ARM: tegra: fix missing include

Ben Dooks
2016-06-10T15:02:16Z

On 10/06/16 15:33, Jon Hunter wrote:
>
> On 10/06/16 15:22, Thierry Reding wrote:
>> * PGP Signed by an unknown key
>>
>> On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote:
>>> The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing
>>> from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h>
>>> so add that include to avoid the following warning:
>>>
>>> arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?
>>>
>>> Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
>>> ---
>>> Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
>>> Cc: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
>>> Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>> ---
>>> arch/arm/mach-tegra/cpuidle.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> I've been carrying a set of patches to fix these, and a couple of other
>> sparse warnings, in my tree locally, but never sent them out because
>> they were so trivial. I probably should've to avoid the duplication of
>> effort. Sorry about that.

Given it is likely that gcc warning flags will be updated
it'd be good to get these issues sorted out.

--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius