From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH 0/14] Sparse fixes for tegra
Date: Fri, 07 Oct 2011 10:54:08 +0200 [thread overview]
Message-ID: <1578886.3aVd19SPzO@wuerfel> (raw)
In-Reply-To: <1317956064-17650-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
On Thursday 06 October 2011 19:54:10 Olof Johansson wrote:
> Some trivial fixes removing sparse warnings on tegra code.
Hi Olof,
That's a very nice series. I had a go at this across platforms before,
but had not finished it yet.
One thing I would recommend instead of having a type cast in IO_ADDRESS
is to change the definition of IO_{IRAM,CPU,PPSB,APB}_VIRT to be
an iomem pointer from the start, so any calculation you do based on
that automatically gets the right type.
In the long run, I would hope to be able to get rid of basically
all uses of IO_ADDRESS and IO_TO_VIRT in the tegra code and replace
that with device tree lookups, but that is clearly a separate issue.
Arnd
next prev parent reply other threads:[~2011-10-07 8:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 2:54 [PATCH 0/14] Sparse fixes for tegra Olof Johansson
[not found] ` <1317956064-17650-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-10-07 2:54 ` [PATCH 01/14] ARM: tegra: add __force to IO_ADDRESS Olof Johansson
2011-10-07 2:54 ` [PATCH 02/14] ARM: tegra: fuse: use IO_ADDRESS Olof Johansson
2011-10-07 2:54 ` [PATCH 03/14] ARM: tegra: pinmux: " Olof Johansson
2011-10-07 2:54 ` [PATCH 04/14] ARM: tegra: timer: don't cast __iomem pointers Olof Johansson
2011-10-07 2:54 ` [PATCH 05/14] ARM: tegra: tegra2_clocks: " Olof Johansson
2011-10-07 2:54 ` [PATCH 06/14] ARM: tegra: tegra2_clocks: 0 -> NULL changes Olof Johansson
2011-10-07 2:54 ` [PATCH 07/14] ARM: tegra: pcie: don't cast __iomem pointers Olof Johansson
2011-10-07 2:54 ` [PATCH 08/14] ARM: tegra: pcie: include board.h Olof Johansson
2011-10-07 2:54 ` [PATCH 09/14] ARM: tegra: pcie: 0 -> NULL changes Olof Johansson
2011-10-07 2:54 ` [PATCH 10/14] ARM: tegra: tegra_init_cache should be static Olof Johansson
2011-10-07 2:54 ` [PATCH 11/14] ARM: tegra: tegra_rtc_read_ms " Olof Johansson
2011-10-07 2:54 ` [PATCH 12/14] ARM: tegra: tegra_powergate_is_powered " Olof Johansson
2011-10-07 2:54 ` [PATCH 13/14] ARM: tegra: tegra2_clocks: don't export some tables Olof Johansson
2011-10-07 2:54 ` [PATCH 14/14] ARM: tegra: dma: staticify some tables and functions Olof Johansson
2011-10-07 8:54 ` Arnd Bergmann [this message]
2011-10-10 5:32 ` [PATCH 0/14] Sparse fixes for tegra Olof Johansson
2011-10-07 15:40 ` Stephen Warren
2011-10-10 5:27 ` [PATCH v2 00/14] " Olof Johansson
[not found] ` <1318224484-2090-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-10-10 5:27 ` [PATCH v2 01/14] ARM: tegra: annotate IO_*_VIRT pointers Olof Johansson
[not found] ` <1318224484-2090-2-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-10-13 14:10 ` Russell King - ARM Linux
[not found] ` <20111013141036.GX21648-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2011-10-13 22:27 ` Olof Johansson
2011-10-10 5:27 ` [PATCH v2 02/14] ARM: tegra: timer: don't cast __iomem pointers Olof Johansson
2011-10-10 5:27 ` [PATCH v2 03/14] ARM: tegra: tegra2_clocks: " Olof Johansson
2011-10-10 5:27 ` [PATCH v2 04/14] ARM: tegra: tegra2_clocks: 0 -> NULL changes Olof Johansson
2011-10-10 5:27 ` [PATCH v2 05/14] ARM: tegra: pcie: don't cast __iomem pointers Olof Johansson
2011-10-10 5:27 ` [PATCH v2 06/14] ARM: tegra: pcie: include board.h Olof Johansson
2011-10-10 5:27 ` [PATCH v2 07/14] ARM: tegra: pcie: 0 -> NULL changes Olof Johansson
2011-10-10 5:27 ` [PATCH v2 08/14] ARM: tegra: tegra_init_cache should be static Olof Johansson
2011-10-10 5:27 ` [PATCH v2 09/14] ARM: tegra: tegra_rtc_read_ms " Olof Johansson
2011-10-10 5:28 ` [PATCH v2 10/14] ARM: tegra: tegra_powergate_is_powered " Olof Johansson
[not found] ` <1318224484-2090-11-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-10-10 10:44 ` Sergei Shtylyov
[not found] ` <4E92CC72.3030809-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2011-10-10 18:11 ` Olof Johansson
2011-10-10 5:28 ` [PATCH v2 11/14] ARM: tegra: tegra2_clocks: don't export some tables Olof Johansson
2011-10-10 5:28 ` [PATCH v2 12/14] ARM: tegra: dma: staticify some tables and functions Olof Johansson
2011-10-10 5:28 ` [PATCH v2 13/14] ARM: tegra: cpu-tegra: sparse type fix Olof Johansson
2011-10-10 5:28 ` [PATCH v2 14/14] ARM: tegra: cpu-tegra: unexport two functions Olof Johansson
2011-10-10 16:49 ` [PATCH v2 00/14] Sparse fixes for tegra Stephen Warren
2011-10-10 17:00 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1578886.3aVd19SPzO@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-kernel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox