Re: [PATCH net-next] i2c: tegra: runtime PM is not IRQ-safe

[Mikko Perttunen <mperttunen@nvidia.com>]

On Wednesday, February 18, 2026 1:46 AM Jon Hunter wrote:
> On 17/02/2026 16:40, Russell King (Oracle) wrote:
> 
> ...
> 
> >> Yes we should always follow that rule. However, in this case, I believe
> >> that the build time dependency on the PINCTRL subsystem was only exposed
> >> by adding the 'i2c_dev->dev->pins'. Unless I am misunderstanding ...
> > 
> > Yes, it looks like it.
> > 
> > However, I wonder why the dependency has to be complicated.
> > 
> > ARCH_TEGRA in both arm64 and arm selects PINCTRL, so we can assume that
> > 
> > PINCTRL will be set for ARCH_TEGRA. So:
> >   config I2C_TEGRA
> >   
> >   	tristate "NVIDIA Tegra internal I2C controller"
> >   	depends on ARCH_TEGRA || (COMPILE_TEST && (ARC || ARM || ARM64 || 
M68K
> >   	|| RISCV || SUPERH || SPARC))> 
> > +	depends on PINCTRL
> > 
> > is a shorter way of writing this, and it makes sense - pinctrl isn't
> > required because we're doing a compile test, it's required because
> > the driver itself fundamentally requires it with this change whether
> > or not we're doing a compile test.
> 
> Yes that's true indeed.
> 
> Mikko, do you want to take care of this?

My thought was it would be better to keep the PINCTRL dependency grouped with 
COMPILE_TEST. That makes it clear it's only needed because of it -- clearer to 
the reader that ARCH_TEGRA implies it. Kind of like not checking for NULL 
pointers in C code when the contract is that the pointer is not NULL.

I can change it though if you'd like.

Mikko

> 
> Jon
> 
> --
> nvpublic