Re: [Patch V2] memory: tegra: Add MC error logging on tegra186 onward

Ashish Mhetre
2022-01-21T05:52:13Z

On 1/20/2022 6:29 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 20.01.2022 12:02, Ashish Mhetre пишет:
>> @@ -521,23 +535,64 @@ static irqreturn_t tegra30_mc_handle_irq(int irq, void *data)
>>
>> for_each_set_bit(bit, &status, 32) {
>> const char *error = tegra_mc_status_names[bit] ?: "unknown";
>> + u32 status_reg = MC_ERR_STATUS, addr_reg = MC_ERR_ADR;
>
> No need to initialize these variables, since they are always initialized
> by the further code.
>
> Please write it like this:
>
> u32 addr_hi_reg = 0, status_reg, addr_reg;
Okay, I will remove initialization.