Re: [Patch V2] memory: tegra: Add MC error logging on tegra186 onward

Ashish Mhetre
2022-01-21T05:53:12Z

On 1/20/2022 6:36 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 20.01.2022 12:02, Ashish Mhetre пишет:
>> + default:
>> + status_reg = MC_ERR_STATUS;
>> + addr_reg = MC_ERR_ADR;
>> +#if defined(CONFIG_ARCH_TEGRA_194_SOC) || \
>> + defined(CONFIG_ARCH_TEGRA_234_SOC)
>> + addr_hi_reg = MC_ERR_ADR_HI;
>> +#endif
>
> I'd add new "has_addr_hi_reg" field to struct tegra_mc_soc and use it
> instead of the ifdefs.
>
> if (mc->soc->has_addr_hi_reg)
> addr_hi_reg = MC_ERR_ADR_HI;
That's a good idea. I'll implement it in that way in next version.