From: Rob Herring <robh@kernel.org>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Richard Leitner <richard.leitner@skidata.com>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Airlie <airlied@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-tegra@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-staging@lists.linux.dev, Daniel Vetter <daniel@ffwll.ch>,
Dmitry Osipenko <digetx@gmail.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/21] dt-bindings: display: tegra: vi: add 'vip' property and example
Date: Fri, 30 Dec 2022 10:34:28 -0600 [thread overview]
Message-ID: <167241769230.1925726.8527129486424295727.robh@kernel.org> (raw)
In-Reply-To: <20221229133205.981397-3-luca.ceresoli@bootlin.com>
On Thu, 29 Dec 2022 14:31:46 +0100, Luca Ceresoli wrote:
> The Tegra20 VI peripheral can receive parallel input from the VIP parallel
> input module. Add it to the allowed properties and augment the existing
> nvidia,tegra20-vi example to show a 'vip' property.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> ---
>
> Changed in v3 (suggested by Rob Herring):
> - drop 'endpoint', unneeded as there's no extra properties in the
> endpoints
>
> Changed in v2 (suggested by Krzysztof Kozlowski):
> - rename "i2c3" -> "ic2"
> - add review tag
> ---
> .../display/tegra/nvidia,tegra20-vi.yaml | 64 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 65 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.example.dtb: vi@54080000: vip: Unevaluated properties are not allowed ('channel@0' was unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.example.dtb: vi@54080000: vip: 'ports' is a required property
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.example.dtb: vip: Unevaluated properties are not allowed ('channel@0' was unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.example.dtb: vip: 'ports' is a required property
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221229133205.981397-3-luca.ceresoli@bootlin.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2022-12-30 16:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 13:31 [PATCH v3 00/21] Add Tegra20 parallel video input capture Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 01/21] dt-bindings: display: tegra: add Tegra20 VIP Luca Ceresoli
2023-01-02 9:42 ` Krzysztof Kozlowski
2023-01-24 22:15 ` Dmitry Osipenko
2023-01-30 14:09 ` Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 02/21] dt-bindings: display: tegra: vi: add 'vip' property and example Luca Ceresoli
2022-12-30 16:34 ` Rob Herring [this message]
2023-01-24 17:02 ` Dmitry Osipenko
2023-01-24 21:14 ` Luca Ceresoli
2023-01-24 22:09 ` Dmitry Osipenko
2022-12-29 13:31 ` [PATCH v3 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 04/21] staging: media: tegra-video: improve documentation of tegra_video_format fields Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 05/21] staging: media: tegra-video: document tegra_channel_get_remote_source_subdev Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 06/21] staging: media: tegra-video: fix typos in comment Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 07/21] staging: media: tegra-video: improve error messages Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 08/21] staging: media: tegra-video: slightly simplify cleanup on errors Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 09/21] staging: media: tegra-video: move private struct declaration to C file Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 10/21] staging: media: tegra-video: move tegra210_csi_soc " Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 11/21] staging: media: tegra-video: remove unneeded include Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 12/21] staging: media: tegra-video: Kconfig: allow TPG only on Tegra210 Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 13/21] staging: media: tegra-video: move tegra_channel_fmt_align to a per-soc op Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 14/21] staging: media: tegra-video: move default format to soc-specific data Luca Ceresoli
2022-12-29 13:31 ` [PATCH v3 15/21] staging: media: tegra-video: move MIPI calibration calls from VI to CSI Luca Ceresoli
2022-12-29 13:32 ` [PATCH v3 16/21] staging: media: tegra-video: add a per-soc enable/disable op Luca Ceresoli
2022-12-29 13:32 ` [PATCH v3 17/21] staging: media: tegra-video: move syncpt init/free to a per-soc op Luca Ceresoli
2022-12-29 13:32 ` [PATCH v3 18/21] staging: media: tegra-video: add syncpts for Tegra20 to struct tegra_vi Luca Ceresoli
2022-12-29 13:32 ` [PATCH v3 19/21] staging: media: tegra-video: add hooks for planar YUV and H/V flip Luca Ceresoli
2022-12-29 13:32 ` [PATCH v3 20/21] staging: media: tegra-video: add H/V flip controls Luca Ceresoli
2022-12-29 13:32 ` [PATCH v3 21/21] staging: media: tegra-video: add support for Tegra20 parallel input Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167241769230.1925726.8527129486424295727.robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=richard.leitner@skidata.com \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox