From: Stephen Boyd <sboyd@kernel.org>
To: Pei Xiao <xiaopei01@kylinos.cn>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, mturquette@baylibre.com,
pdeschrijver@nvidia.com, pgaikwad@nvidia.com
Cc: Pei Xiao <xiaopei01@kylinos.cn>
Subject: Re: [PATCH 1/2] clk: tegra: periph: Fix error handling and resolve unsigned compare warning
Date: Thu, 24 Jul 2025 15:31:27 -0700 [thread overview]
Message-ID: <175339628791.3513.14767621631435473302@lazor> (raw)
In-Reply-To: <79c7f01e29876c612e90d6d0157fb1572ca8b3fb.1752046270.git.xiaopei01@kylinos.cn>
Quoting Pei Xiao (2025-07-09 00:37:13)
> ./drivers/clk/tegra/clk-periph.c:59:5-9: WARNING:
> Unsigned expression compared with zero: rate < 0
>
> The unsigned long 'rate' variable caused:
> - Incorrect handling of negative errors
> - Compile warning: "Unsigned expression compared with zero"
>
> Fix by changing to long type and adding req->rate cast.
>
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
Applied to clk-next
next prev parent reply other threads:[~2025-07-24 22:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 7:37 [PATCH 0/2] clean up in tegra clk Pei Xiao
2025-07-09 7:37 ` [PATCH 1/2] clk: tegra: periph: Fix error handling and resolve unsigned compare warning Pei Xiao
2025-07-09 12:08 ` Thierry Reding
2025-07-24 22:31 ` Stephen Boyd [this message]
2025-07-09 7:37 ` [PATCH 2/2] clk: tegra: periph: Make tegra_clk_periph_ops static Pei Xiao
2025-07-09 12:09 ` Thierry Reding
2025-07-24 22:31 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175339628791.3513.14767621631435473302@lazor \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=xiaopei01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox