From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12835C2FC0E for ; Fri, 18 Aug 2023 01:27:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357021AbjHRB0e (ORCPT ); Thu, 17 Aug 2023 21:26:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357098AbjHRB00 (ORCPT ); Thu, 17 Aug 2023 21:26:26 -0400 X-Greylist: delayed 94 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 17 Aug 2023 18:25:51 PDT Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55B1E3C14 for ; Thu, 17 Aug 2023 18:25:51 -0700 (PDT) Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTP id Wm2GqzFyRfaVXWoDGqSKxv; Fri, 18 Aug 2023 01:23:42 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id WoDFqBXKtyB3AWoDFqKP7f; Fri, 18 Aug 2023 01:23:42 +0000 X-Authority-Analysis: v=2.4 cv=UZlC9YeN c=1 sm=1 tr=0 ts=64dec81e a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=WzbPXH4gqzPVN0x6HrNMNA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=UttIx32zK-AA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=pFyQfRViAAAA:8 a=cm27Pg_UAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=oJz5jJLG1JtSoe7EL652:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=o/+pO3PIu+Y61Kvz7emltSb9pfrpT5BKJMwFpbJx990=; b=gnDTM/eokucdSfrXYpZWTvzo9y PnhEJcdKe+ysvz++MjaS7mXcLzRp+VQsTcaEcrJDiMoOcHSes2URK+vfTyEztz1Fl0eOu7wgAD2m9 fR3aG6737S+LuG8WSbjRHsGBoNWnM8SQnO0gapIJtNSw0Xs7NF/PU+elgfTv+9Y66iDBwj9GVDu5L mExbhtCFUqk0DfTTtzTJYyNvZgSmwuMcQPkbWFrG5vGwRZSzVA1yAtdb4F3jfg3g2C54oDKCzPVCu d7AvgRutV3bGjyTpDDZAtvvi0WMAFSQ1li7COg+sKwN+uUlKHpyc3rfvft0OYXPOCeE7PhOevogQy vtEChXHg==; Received: from 187-162-21-192.static.axtel.net ([187.162.21.192]:42794 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qWoD9-000Vx3-2f; Thu, 17 Aug 2023 20:23:35 -0500 Message-ID: <1a0c3c57-6a83-28d9-18e6-29aaedcd9507@embeddedor.com> Date: Thu, 17 Aug 2023 19:24:34 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 09/21] dmaengine: sf-pdma: Annotate struct sf_pdma with __counted_by Content-Language: en-US To: Kees Cook , Vinod Koul Cc: Green Wan , dmaengine@vger.kernel.org, Hector Martin , Sven Peter , Alyssa Rosenzweig , Ludovic Desroches , Tudor Ambarus , Lars-Peter Clausen , Zhou Wang , Jie Hai , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Laxman Dewangan , Jon Hunter , Thierry Reding , Peter Ujfalusi , Kunihiko Hayashi , Masami Hiramatsu , Yu Kuai , Greg Kroah-Hartman , Jordy Zomer , Jernej Skrabec , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230817235428.never.111-kees@kernel.org> <20230817235859.49846-9-keescook@chromium.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230817235859.49846-9-keescook@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.21.192 X-Source-L: No X-Exim-ID: 1qWoD9-000Vx3-2f X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-21-192.static.axtel.net ([192.168.15.8]) [187.162.21.192]:42794 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 255 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCnpzPAIqllkkXLHn/WnCf2kYrAefEppsJpdDFMGfpzpNhmeIuQ6cHyX6/BdVubCy7NOnyu0ktZhS2F0OPCo0dSRaAKTdNQh3ajZfmR3ZdooenmnBc1t DnwG4kZkF/+/Mr/ISWMEdB3GmsggjGluCz8gLRV2FxVk9PJIdEA+QEw2FO6A0ffeP/iXOLPFlAnBON2Iv5mzLH7P1Ru7DBDeQ1CXCcxq2uQD73NRVvRnDg2U Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 8/17/23 17:58, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct sf_pdma. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Vinod Koul > Cc: Green Wan > Cc: dmaengine@vger.kernel.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/dma/sf-pdma/sf-pdma.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/sf-pdma/sf-pdma.h b/drivers/dma/sf-pdma/sf-pdma.h > index 5c398a83b491..d05772b5d8d3 100644 > --- a/drivers/dma/sf-pdma/sf-pdma.h > +++ b/drivers/dma/sf-pdma/sf-pdma.h > @@ -113,7 +113,7 @@ struct sf_pdma { > void __iomem *membase; > void __iomem *mappedbase; > u32 n_chans; > - struct sf_pdma_chan chans[]; > + struct sf_pdma_chan chans[] __counted_by(n_chans); > }; > > #endif /* _SF_PDMA_H */