From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v3 3/4] usb: host: Add EHCI driver for NVIDIA Tegra SoCs Date: Thu, 17 Feb 2011 14:27:15 -0800 Message-ID: <20110217222715.GA22126@suse.de> References: <1297980904-23466-1-git-send-email-benoit@android.com> <1297980904-23466-4-git-send-email-benoit@android.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1297980904-23466-4-git-send-email-benoit-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Benoit Goby Cc: David Brownell , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Robert Morell , Olof Johansson , Erik Gilling , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Thu, Feb 17, 2011 at 02:15:03PM -0800, Benoit Goby wrote: > Signed-off-by: Benoit Goby No changelog comment saying what this is, what it does, or even why one would want this? Come on, you can do better, please redo. At the very least, use the same wording you have in your Kconfig entry, but to do that would be just phoning it in... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html