Re: [PATCH v5 3/4] usb: host: Add EHCI driver for NVIDIA Tegra SoCs

[Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>]

On Tue, Feb 22, 2011 at 08:56:47PM -0800, Olof Johansson wrote:
> Hi,
> 
> 
> On Tue, Feb 22, 2011 at 8:07 PM, Benoit Goby <benoit-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org> wrote:
> 
> 
> > diff --git a/include/linux/tegra_usb.h b/include/linux/tegra_usb.h
> > new file mode 100644
> > index 0000000..6bca5b5
> > --- /dev/null
> > +++ b/include/linux/tegra_usb.h
> > @@ -0,0 +1,31 @@
> > +/*
> > + * Copyright (C) 2010 Google, Inc.
> > + *
> > + * This software is licensed under the terms of the GNU General Public
> > + * License version 2, as published by the Free Software Foundation, and
> > + * may be copied, distributed, and modified under those terms.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + */
> > +
> > +#ifndef _TEGRA_USB_H_
> > +#define _TEGRA_USB_H_
> > +
> > +enum tegra_usb_operating_modes {
> > +       TEGRA_USB_DEVICE,
> > +       TEGRA_USB_HOST,
> > +       TEGRA_USB_OTG,
> > +};
> > +
> > +struct tegra_ehci_platform_data {
> > +       enum tegra_usb_operating_modes operating_mode;
> > +       /* power down the phy on bus suspend */
> > +       int power_down_on_bus_suspend;
> > +       void *phy_config;
> > +};
> > +
> > +#endif /* _TEGRA_USB_H_ */
> 
> Most other platform drivers like this put the platform data include
> files either under include/linux/usb or under
> arch/arm/mach-<foo>/include/mach instead, since they don't really
> apply globally.  I'd say go with the latter since there's no sharing
> of this outside of tegra today (and it can be moved if that ever
> happens).

Platform data should go in include/linux/platform_data/  Please put it
there and not in the "global" include/linux/ location.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html