public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Marvin <marvin24@gmx.de>
To: Mike Rapoport <mike@compulab.co.il>
Cc: linux-tegra@vger.kernel.org, Olof Johansson <olof@lixom.net>,
	linux-arm-kernel@lists.infradead.org,
	Erik Gilling <konkers@android.com>,
	Colin Cross <ccross@android.com>
Subject: Re: [PATCH 2/3] ARM: tegra: harmony: initialize the TPS65862 PMIC
Date: Wed, 9 Mar 2011 12:14:26 +0100	[thread overview]
Message-ID: <201103091214.26718.marvin24@gmx.de> (raw)
In-Reply-To: <4D771CE3.6020606@compulab.co.il>

> On 03/09/11 00:12, Marc Dietrich wrote:
> > Am Dienstag 08 März 2011, um 13:58:58 schrieb Mike Rapoport:
> >>
> >> diff --git a/arch/arm/mach-tegra/board-harmony-power.c b/arch/arm/mach-tegra/board-harmony-power.c
> >> new file mode 100644
> >> index 0000000..ca43d7a
> >> --- /dev/null
> >> +++ b/arch/arm/mach-tegra/board-harmony-power.c
> > ...
> >> +static struct i2c_board_info __initdata harmony_regulators[] = {
> >> +	{
> >> +		I2C_BOARD_INFO("tps6586x", 0x34),
> >> +		.irq		= INT_EXTERNAL_PMU,
> >> +		.platform_data	= &tps_platform,
> >> +	},
> >> +};
> >> +
> >> +int __init harmony_regulator_init(void)
> >> +{
> >> +	i2c_register_board_info(3, harmony_regulators, 1);
> > 
> > I don't know harmony well, but are you sure this is 3, not 4, as on all other boards?
> 
> In the mainline version of i2c-tegra the adapter (and therefore bus) number
> equals the platform device id, and in case of DVC adapter it's 3.

Thanks for clarification. I guess this saved me from some headaches.

Marc

  reply	other threads:[~2011-03-09 11:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08 12:58 [PATCH 0/3] Harmony PCI-e and regulators Mike Rapoport
     [not found] ` <cover.1299588456.git.mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-03-08 12:58   ` [PATCH 1/3] ARM: tegra: harmony: update PCI-e initialization sequence Mike Rapoport
2011-03-08 12:58   ` [PATCH 2/3] ARM: tegra: harmony: initialize the TPS65862 PMIC Mike Rapoport
     [not found]     ` <4ade6d195fff78271085eafb0a99de3be8beb426.1299588456.git.mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-03-08 13:15       ` Mark Brown
     [not found]         ` <20110308131541.GB5892-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2011-03-09  7:41           ` Mike Rapoport
     [not found]             ` <4D772F23.70304-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-03-09 10:15               ` Mark Brown
     [not found]                 ` <20110309101508.GD6923-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-03-09 11:53                   ` Mike Rapoport
     [not found]                     ` <4D776A42.9030107-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-03-09 12:22                       ` Mark Brown
     [not found]                         ` <20110309122222.GG6923-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-03-09 13:19                           ` Mike Rapoport
     [not found]                             ` <4D777E6C.5040000-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-03-09 13:15                               ` Mark Brown
     [not found]                                 ` <20110309131511.GB30257-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-03-09 13:23                                   ` Mike Rapoport
2011-03-08 22:12       ` Marc Dietrich
     [not found]         ` <201103082312.06911.marvin24-Mmb7MZpHnFY@public.gmane.org>
2011-03-09  6:23           ` Mike Rapoport
2011-03-09 11:14             ` Marvin [this message]
2011-03-08 12:58   ` [PATCH 3/3] ARM: tegra: update defconfig Mike Rapoport
2011-03-08 18:06   ` [PATCH 0/3] Harmony PCI-e and regulators Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103091214.26718.marvin24@gmx.de \
    --to=marvin24@gmx.de \
    --cc=ccross@android.com \
    --cc=konkers@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mike@compulab.co.il \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox