Re: [patch 02/23] arm: tegra: Remove unused function which fiddles with irq_desc

Thomas Gleixner
2011-03-26T20:24:50Z

On Sun, 27 Mar 2011, Varun Wadekar wrote:
>
> Thomas, then how do you think we should handle restoring of gpio states
> across suspend-resume cycles?

That code is unused. Period. No caller, nothing nada. So what does it
handle?

> > -
> > - for (i = INT_GPIO_BASE; i < (INT_GPIO_BASE + TEGRA_NR_GPIOS); i++) {
> > - struct irq_desc *desc = irq_to_desc(i);
> > - if (!desc || (desc->status & IRQ_WAKEUP))
> > - continue;
> > - enable_irq(i);
> > - }

And this part is totally unacceptable and should have never been
merged. Further it is in the way of cleanups to the core code and as
there is no user I'm not willing to even think about what it does and
why it is there.

FYI, the core code deals with interrupt suspending/resuming
already. So if there is a problem with that which does not cover your
specific problem, then you better talk to me before hacking up such
private workarounds and expecting that I tolerate them in unused code.

Thanks,

tglx